github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-06 18:53:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

return a 400 status code for invalid moves

Browse source 
was previously returning 500
This commit is contained in:
Brian Gough 2018-01-26 17:00:55 +00:00
parent cd2688a740
commit b30dd22f0e
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/web/app/coffee/Features/Editor/EditorHttpController.coffee
View file

@ -128,8 +128,12 @@ module.exports = EditorHttpController =
folder_id = req.body.folder_id
user_id = AuthenticationController.getLoggedInUserId(req)
EditorController.moveEntity project_id, entity_id, folder_id, entity_type, user_id, (error) ->
return next(error) if error?
res.sendStatus 204
if error?.message == 'destination folder is a child folder of me'
res.status(400).json(req.i18n.translate('invalid_file_name'))
else if error?
next(error)
else
res.sendStatus 204
deleteDoc: (req, res, next)->
req.params.entity_type = "doc"