From b005f8233ed8963dfb7542afb70deb5ba79927f7 Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Mon, 29 Feb 2016 15:52:02 +0000 Subject: [PATCH] guard against null and undefined keys in `\cite{}` autocomplete --- .../auto-complete/AutoCompleteManager.coffee | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/services/web/public/coffee/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.coffee b/services/web/public/coffee/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.coffee index a8afdeaa44..7b4889a81e 100644 --- a/services/web/public/coffee/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.coffee +++ b/services/web/public/coffee/ide/editor/directives/aceEditor/auto-complete/AutoCompleteManager.coffee @@ -66,12 +66,13 @@ define [ } if references.keys and references.keys.length > 0 references.keys.forEach (key) -> - result.push({ - caption: "\\#{commandName}{#{previousArgsCaption}#{key}", - value: "\\#{commandName}{#{previousArgs}#{key}", - meta: "reference", - score: 10000 - }) + if !(key in [null, undefined]) + result.push({ + caption: "\\#{commandName}{#{previousArgsCaption}#{key}", + value: "\\#{commandName}{#{previousArgs}#{key}", + meta: "reference", + score: 10000 + }) callback null, result else callback null, result