github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

retry lock with exponential backoff

Browse source
This commit is contained in:
Brian Gough 2018-05-04 13:43:12 +01:00
parent e414100c41
commit afd4a10a19
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/web/app/coffee/infrastructure/LockManager.coffee
View file

@ -13,6 +13,7 @@ COUNT = 0
module.exports = LockManager =
LOCK_TEST_INTERVAL: 50 # 50ms between each test of the lock
MAX_TEST_INTERVAL: 1000 # back off to 1s between each test of the lock
MAX_LOCK_WAIT_TIME: 10000 # 10s maximum time to spend trying to get the lock
REDIS_LOCK_EXPIRY: 30 # seconds. Time until lock auto expires in redis
SLOW_EXECUTION_THRESHOLD: 5000 # 5s, if execution takes longer than this then log
@ -69,6 +70,7 @@ module.exports = LockManager =
_getLock: (key, namespace, callback = (error, lockValue) ->) ->
startTime = Date.now()
testInterval = LockManager.LOCK_TEST_INTERVAL
attempts = 0
do attempt = () ->
if Date.now() - startTime > LockManager.MAX_LOCK_WAIT_TIME
@ -82,7 +84,9 @@ module.exports = LockManager =
metrics.gauge "lock.#{namespace}.get.success.tries", attempts
callback(null, lockValue)
else
setTimeout attempt, LockManager.LOCK_TEST_INTERVAL
setTimeout attempt, testInterval
# back off when the lock is taken to avoid overloading
testInterval = Math.min(testInterval * 2, LockManager.MAX_TEST_INTERVAL)
_releaseLock: (key, lockValue, callback)->
rclient.eval LockManager.unlockScript, 1, key, lockValue, (err, result) ->

1
services/web/test/unit/coffee/infrastructure/LockManager/ReleasingTheLock.coffee
View file

@ -17,7 +17,6 @@ describe 'LockManager - releasing the lock', ()->
auth:->
eval:deleteStub
LockManager = SandboxedModule.require(modulePath, requires: mocks)
LockManager.unlockScript = "this is the unlock script"