github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-19 16:15:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3510 from overleaf/jpa-fix-cm-listener-signature

Browse source 
[frontend] EditorWatchdogManager: fix signature of CM 'change' handler

GitOrigin-RevId: 9803876db052533de156087d38eb2a9486eb341f
This commit is contained in:
Jakob Ackermann 2021-01-07 09:55:45 +00:00 • committed by Copybot
parent 8779e731e1
commit ae511474f2
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
services/web/frontend/js/ide/connection/EditorWatchdogManager.js
View file

@ -177,9 +177,21 @@ export default class EditorWatchdogManager {
}
attachToEditor(editorName, editor) {
const onChange = change => {
// Ignore remote changes.
if (change.origin !== 'remote') this.onEdit()
let onChange
if (editorName === 'CM') {
// CM is passing the CM instance as first parameter, then the change.
onChange = (editor, change) => {
// Ignore remote changes.
if (change.origin === 'remote') return
this.onEdit()
}
} else {
// ACE is passing the change object as first parameter.
onChange = change => {
// Ignore remote changes.
if (change.origin === 'remote') return
this.onEdit()
}
}
this._log('attach to editor', editorName)
editor.on('change', onChange)