github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-11 18:43:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add missing return on callback

Browse source
This commit is contained in:
James Allen 2016-09-30 13:36:31 +01:00
parent deced1aa15
commit a7f44bcd01
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/track-changes/app/coffee/DiffManager.coffee
View file

@ -71,7 +71,7 @@ module.exports = DiffManager =
if lastUpdate? and lastUpdate.v != version - 1
error = new Error("latest update version, #{lastUpdate.v}, does not match doc version, #{version}")
error.retry = true
callback error
return callback error
logger.log {docVersion: version, lastUpdateVersion: lastUpdate?.v, updateCount: updates.length}, "rewinding updates"

4
services/track-changes/test/unit/coffee/DiffManager/DiffManagerTests.coffee
View file

@ -204,9 +204,7 @@ describe "DiffManager", ->
@DiffManager._tryGetDocumentBeforeVersion @project_id, @doc_id, @fromVersion, @callback
it "should call the callback with an error with retry = true set", ->
@callback
.calledWith(new Error("latest update version, 40, does not match doc version, 42"))
.should.equal true
@callback.calledOnce.should.equal true
error = @callback.args[0][0]
expect(error.retry).to.equal true