github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-29 18:43:42 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #67 from overleaf/sk-dont-catch-throwable-swap-impl

Browse source 
Don't catch `Throwable` in swap-job, catch Exception
This commit is contained in:
Shane Kilkelly 2019-06-13 12:11:01 +01:00 committed by GitHub
commit a68afc2e28
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/bridge/swap/job/SwapJobImpl.java
View file

@ -139,8 +139,8 @@ public class SwapJobImpl implements SwapJob {
String projectName = dbStore.getOldestUnswappedProject(); String projectName = dbStore.getOldestUnswappedProject();
try { try {
evict(projectName); evict(projectName);
} catch (Throwable t) { } catch (Exception e) {
Log.warn("[{}] Exception while swapping, mark project and move on", projectName, t); Log.warn("[{}] Exception while swapping, mark project and move on", projectName, e);
// NOTE: this is something of a hack. If a project fails to swap we get stuck in a // NOTE: this is something of a hack. If a project fails to swap we get stuck in a
// loop where `dbStore.getOldestUnswappedProject()` gives the same failing project over and over again, // loop where `dbStore.getOldestUnswappedProject()` gives the same failing project over and over again,
// which fills up the disk with errors. By touching the access time we can mark the project as a // which fills up the disk with errors. By touching the access time we can mark the project as a