github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

extend comment re disconnection

Browse source
This commit is contained in:
Brian Gough 2019-07-19 08:56:38 +01:00
parent 616014e05d
commit a538d10488
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
services/real-time/app/coffee/RoomManager.coffee
View file

@ -26,9 +26,11 @@ module.exports = RoomManager =
@_leave client, "doc", doc_id
leaveProjectAndDocs: (client) ->
# what rooms is this client in? we need to leave them all
# FIXME: socket.io will cause us to leave the rooms, so we only need
# to manage our channel subscriptions
# what rooms is this client in? we need to leave them all. socket.io
# will cause us to leave the rooms, so we only need to manage our
# channel subscriptions... but it will be safer if we leave them
# explicitly, and then socket.io will just regard this as a client that
# has not joined any rooms and do a final disconnection.
for id in @_roomsClientIsIn(client)
entity = IdMap.get(id)
@_leave client, entity, id
@ -36,6 +38,9 @@ module.exports = RoomManager =
eventSource: () ->
return RoomEvents
# internal functions below, these access socket.io rooms data directly and
# will need updating for socket.io v2
_clientsInRoom: (client, room) ->
nsp = client.namespace.name
name = (nsp + '/') + room;