From a278e70b27fc594824fb8292422df7974399a491 Mon Sep 17 00:00:00 2001
From: Antoine Clausse <antoine.clausse@overleaf.com>
Date: Tue, 6 Aug 2024 15:53:11 +0200
Subject: [PATCH] [web] Fix UpgradePrompt in Editor - Retrieve `isMember` from
 `userIsMemberOfGroupSubscription` (#19810)

* Fix: Retrieve `isMember` from `userIsMemberOfGroupSubscription`

* Inline `userIsMemberOfGroupSubscription` call

GitOrigin-RevId: b8b339bbce3934b0b83bf6d805ab6ef6225d43e7
---
 .../web/app/src/Features/Project/ProjectController.js    | 9 ++++++---
 .../web/test/unit/src/Project/ProjectControllerTests.js  | 2 +-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js
index 38a4384821..84287cd84a 100644
--- a/services/web/app/src/Features/Project/ProjectController.js
+++ b/services/web/app/src/Features/Project/ProjectController.js
@@ -415,9 +415,12 @@ const _ProjectController = {
           collaberator_refs: 1, // used for link sharing analytics
         }),
         userIsMemberOfGroupSubscription: sessionUser
-          ? LimitationsManager.promises.userIsMemberOfGroupSubscription(
-              sessionUser
-            )
+          ? (async () =>
+              (
+                await LimitationsManager.promises.userIsMemberOfGroupSubscription(
+                  sessionUser
+                )
+              ).isMember)()
           : false,
         _flushToTpds:
           TpdsProjectFlusher.promises.flushProjectToTpdsIfNeeded(projectId),
diff --git a/services/web/test/unit/src/Project/ProjectControllerTests.js b/services/web/test/unit/src/Project/ProjectControllerTests.js
index 930de4b090..adfa4c1165 100644
--- a/services/web/test/unit/src/Project/ProjectControllerTests.js
+++ b/services/web/test/unit/src/Project/ProjectControllerTests.js
@@ -994,7 +994,7 @@ describe('ProjectController', function () {
       it('should not show for a user who is a member of a group subscription', function (done) {
         this.LimitationsManager.promises.userIsMemberOfGroupSubscription = sinon
           .stub()
-          .resolves(true)
+          .resolves({ isMember: true })
         this.res.render = (pageName, opts) => {
           expect(opts.showUpgradePrompt).to.equal(false)
           done()