github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #4256 from overleaf/ab-analytics-manager-nullcheck-userid

Browse source 
Add null checks on userId to all AnalyticsManager functions

GitOrigin-RevId: ca4d50c9309aadf0145fd5135bbdecb7d297ea6f
This commit is contained in:
Alexandre Bourdin 2021-06-24 11:34:26 +02:00 committed by Copybot
parent 7df57174ca
commit a0dd439e2c
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
services/web/app/src/Features/Analytics/AnalyticsManager.js
View file

@ -7,6 +7,9 @@ const analyticsEditingSessionsQueue = Queues.getAnalyticsEditingSessionsQueue()
const analyticsUserPropertiesQueue = Queues.getAnalyticsUserPropertiesQueue()
function identifyUser(userId, oldUserId) {
if (!userId || !oldUserId) {
return
}
if (isAnalyticsDisabled() || isSmokeTestUser(userId)) {
return
}
@ -22,6 +25,9 @@ function identifyUser(userId, oldUserId) {
}
function recordEvent(userId, event, segmentation) {
if (!userId) {
return
}
if (isAnalyticsDisabled() || isSmokeTestUser(userId)) {
return
}
@ -37,6 +43,9 @@ function recordEvent(userId, event, segmentation) {
}
function updateEditingSession(userId, projectId, countryCode) {
if (!userId) {
return
}
if (isAnalyticsDisabled() || isSmokeTestUser(userId)) {
return
}
@ -61,6 +70,9 @@ function updateEditingSession(userId, projectId, countryCode) {
}
function setUserProperty(userId, propertyName, propertyValue) {
if (!userId) {
return
}
if (isAnalyticsDisabled() || isSmokeTestUser(userId)) {
return
}