github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Wrap insert and delete entries in a directive

Browse source
This commit is contained in:
Paulo Reis 2016-11-16 14:56:34 +00:00
parent d7d21b106c
commit 9ffb05cd98
3 changed files with 40 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
services/web/app/views/project/editor/review-panel.jade
View file

@ -32,27 +32,13 @@
ng-class="[ 'rp-entry-' + entry.type, (commentState.adding ? 'rp-entry-adding-comment' : ''), (entry.focused ? 'rp-entry-focused' : '')]" ng-class="[ 'rp-entry-' + entry.type, (commentState.adding ? 'rp-entry-adding-comment' : ''), (entry.focused ? 'rp-entry-focused' : '')]"
) )
div(ng-if="entry.type == 'insert' || entry.type == 'delete'") div(ng-if="entry.type == 'insert' || entry.type == 'delete'")
.rp-entry-header change-entry(
.rp-entry-action-icon(ng-switch="entry.type") entry="entry"
i.fa.fa-pencil(ng-switch-when="insert") author="users[entry.metadata.user_id]"
i.rp-icon-delete(ng-switch-when="delete") on-reject="rejectChange(entry_id);"
on-accept="acceptChange(entry_id);"
)
.rp-entry-metadata
p.rp-entry-metadata-line(style="color: hsl({{ users[entry.metadata.user_id].hue }}, 70%, 50%);") {{ users[entry.metadata.user_id].name }}
p.rp-entry-metadata-line {{ entry.metadata.ts | date : 'MMM d, y h:mm a' }}
.rp-avatar(style="background-color: hsl({{ users[entry.metadata.user_id].hue }}, 70%, 50%);") {{ users[entry.metadata.user_id].avatar_text }}
.rp-entry-body(ng-switch="entry.type")
span(ng-switch-when="insert") Added 
ins.rp-content-highlight {{ entry.content }}
span(ng-switch-when="delete") Deleted 
del.rp-content-highlight {{ entry.content }}
.rp-entry-actions
a.rp-entry-button(href, ng-click="rejectChange(entry_id)")
i.fa.fa-times
|  Reject
a.rp-entry-button(href, ng-click="acceptChange(entry_id)")
i.fa.fa-check
|  Accept
div(ng-if="entry.type == 'comment'") div(ng-if="entry.type == 'comment'")
.rp-comment( .rp-comment(
ng-repeat="comment in entry.thread" ng-repeat="comment in entry.thread"
@ -221,5 +207,25 @@
script(type='text/ng-template', id='changeEntryTemplate') script(type='text/ng-template', id='changeEntryTemplate')
.rp-entry-header
.rp-entry-action-icon(ng-switch="entry.type")
i.fa.fa-pencil(ng-switch-when="insert")
i.rp-icon-delete(ng-switch-when="delete")
.rp-entry-metadata
p.rp-entry-metadata-line(style="color: hsl({{ author.hue }}, 70%, 50%);") {{ author.name }}
p.rp-entry-metadata-line {{ entry.metadata.ts | date : 'MMM d, y h:mm a' }}
.rp-avatar(style="background-color: hsl({{ author.hue }}, 70%, 50%);") {{ author.avatar_text }}
.rp-entry-body(ng-switch="entry.type")
span(ng-switch-when="insert") Added 
ins.rp-content-highlight {{ entry.content }}
span(ng-switch-when="delete") Deleted 
del.rp-content-highlight {{ entry.content }}
.rp-entry-actions
a.rp-entry-button(href, ng-click="onReject();")
i.fa.fa-times
|  Reject
a.rp-entry-button(href, ng-click="onAccept();")
i.fa.fa-check
|  Accept
script(type='text/ng-template', id='commentEntryTemplate') script(type='text/ng-template', id='commentEntryTemplate')

2
services/web/public/coffee/ide/review-panel/ReviewPanelManager.coffee
View file

@ -1,4 +1,6 @@
define [ define [
"ide/review-panel/controllers/ReviewPanelController" "ide/review-panel/controllers/ReviewPanelController"
"ide/review-panel/directives/reviewPanelSorted" "ide/review-panel/directives/reviewPanelSorted"
"ide/review-panel/directives/changeEntry"
"ide/review-panel/directives/commentEntry"
], () -> ], () ->

12
services/web/public/coffee/ide/review-panel/directives/changeEntry.coffee Normal file
View file

@ -0,0 +1,12 @@
define [
"base"
], (App) ->
App.directive "changeEntry", () ->
restrict: "E"
templateUrl: "changeEntryTemplate"
scope:
entry: "="
author: "="
onAccept: "&"
onReject: "&"