github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-01 04:53:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #54 from overleaf/bg-use-background-flush-on-disconnect

Browse source 
use background flush on disconnect
This commit is contained in:
Brian Gough 2019-06-03 10:53:43 +01:00 committed by GitHub
commit 9da98614c7
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/real-time/app/coffee/DocumentUpdaterManager.coffee
View file

@ -36,9 +36,11 @@ module.exports = DocumentUpdaterManager =
callback err callback err
flushProjectToMongoAndDelete: (project_id, callback = ()->) -> flushProjectToMongoAndDelete: (project_id, callback = ()->) ->
# this method is called when the last connected user leaves the project
logger.log project_id:project_id, "deleting project from document updater" logger.log project_id:project_id, "deleting project from document updater"
timer = new metrics.Timer("delete.mongo.project") timer = new metrics.Timer("delete.mongo.project")
url = "#{settings.apis.documentupdater.url}/project/#{project_id}" # flush the project in the background when all users have left
url = "#{settings.apis.documentupdater.url}/project/#{project_id}?background=true"
request.del url, (err, res, body)-> request.del url, (err, res, body)->
timer.done() timer.done()
if err? if err?

2
services/real-time/test/unit/coffee/DocumentUpdaterManagerTests.coffee
View file

@ -93,7 +93,7 @@ describe 'DocumentUpdaterManager', ->
@DocumentUpdaterManager.flushProjectToMongoAndDelete @project_id, @callback @DocumentUpdaterManager.flushProjectToMongoAndDelete @project_id, @callback
it 'should delete the project from the document updater', -> it 'should delete the project from the document updater', ->
url = "#{@settings.apis.documentupdater.url}/project/#{@project_id}" url = "#{@settings.apis.documentupdater.url}/project/#{@project_id}?background=true"
@request.del.calledWith(url).should.equal true @request.del.calledWith(url).should.equal true
it "should call the callback with no error", -> it "should call the callback with no error", ->