github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-16 19:51:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

Copy-on-delete before unlocking

Browse source
This commit is contained in:
Simon Detheridge 2020-03-16 15:53:45 +00:00
parent 06c4c0f74f
commit 9b658dda18
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/filestore/app/js/GcsPersistor.js
View file

@ -179,9 +179,6 @@ async function deleteFile(bucketName, key) {
try {
const file = storage.bucket(bucketName).file(key)
if (settings.filestore.gcs.unlockBeforeDelete) {
await file.setMetadata({ eventBasedHold: false })
}
if (settings.filestore.gcs.deletedBucketSuffix) {
await file.copy(
storage
@ -189,6 +186,9 @@ async function deleteFile(bucketName, key) {
.file(`${key}-${new Date()}`)
)
}
if (settings.filestore.gcs.unlockBeforeDelete) {
await file.setMetadata({ eventBasedHold: false })
}
await file.delete()
} catch (err) {
const error = PersistorHelper.wrapError(