From 9b009efd4615753430b95140f88197757ecec91c Mon Sep 17 00:00:00 2001
From: Eric Mc Sween <eric.mcsween@overleaf.com>
Date: Tue, 23 Mar 2021 15:09:12 -0400
Subject: [PATCH] Upgrade to Node 12

---
 services/track-changes/.nvmrc             | 2 +-
 services/track-changes/Dockerfile         | 2 +-
 services/track-changes/Makefile           | 6 ++++--
 services/track-changes/buildscript.txt    | 4 ++--
 services/track-changes/docker-compose.yml | 4 ++--
 5 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/services/track-changes/.nvmrc b/services/track-changes/.nvmrc
index 2baa2d433a..e68b860383 100644
--- a/services/track-changes/.nvmrc
+++ b/services/track-changes/.nvmrc
@@ -1 +1 @@
-10.23.1
+12.21.0
diff --git a/services/track-changes/Dockerfile b/services/track-changes/Dockerfile
index 2da67d2436..4f417a2a4b 100644
--- a/services/track-changes/Dockerfile
+++ b/services/track-changes/Dockerfile
@@ -2,7 +2,7 @@
 # Instead run bin/update_build_scripts from
 # https://github.com/sharelatex/sharelatex-dev-environment
 
-FROM node:10.23.1 as base
+FROM node:12.21.0 as base
 
 WORKDIR /app
 
diff --git a/services/track-changes/Makefile b/services/track-changes/Makefile
index eaff3428ca..664e4ca96d 100644
--- a/services/track-changes/Makefile
+++ b/services/track-changes/Makefile
@@ -21,8 +21,10 @@ DOCKER_COMPOSE_TEST_UNIT = \
 	COMPOSE_PROJECT_NAME=test_unit_$(BUILD_DIR_NAME) $(DOCKER_COMPOSE)
 
 clean:
-	docker rmi ci/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER)
-	docker rmi gcr.io/overleaf-ops/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER)
+	-docker rmi ci/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER)
+	-docker rmi gcr.io/overleaf-ops/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER)
+	-$(DOCKER_COMPOSE_TEST_UNIT) down --rmi local
+	-$(DOCKER_COMPOSE_TEST_ACCEPTANCE) down --rmi local
 
 format:
 	$(DOCKER_COMPOSE) run --rm test_unit npm run --silent format
diff --git a/services/track-changes/buildscript.txt b/services/track-changes/buildscript.txt
index 205e7f63be..fb68280822 100644
--- a/services/track-changes/buildscript.txt
+++ b/services/track-changes/buildscript.txt
@@ -3,6 +3,6 @@ track-changes
 --docker-repos=gcr.io/overleaf-ops
 --env-add=AWS_BUCKET=bucket
 --env-pass-through=
---node-version=10.23.1
+--node-version=12.21.0
 --public-repo=True
---script-version=3.4.0
+--script-version=3.7.0
diff --git a/services/track-changes/docker-compose.yml b/services/track-changes/docker-compose.yml
index e0afc49351..89df8581d7 100644
--- a/services/track-changes/docker-compose.yml
+++ b/services/track-changes/docker-compose.yml
@@ -6,7 +6,7 @@ version: "2.3"
 
 services:
   test_unit:
-    image: node:10.23.1
+    image: node:12.21.0
     volumes:
       - .:/app
     working_dir: /app
@@ -18,7 +18,7 @@ services:
     user: node
 
   test_acceptance:
-    image: node:10.23.1
+    image: node:12.21.0
     volumes:
       - .:/app
     working_dir: /app