github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-29 08:54:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #5348 from overleaf/ab-alpha-beta-properties

Browse source 
alpha and beta program user properties

GitOrigin-RevId: 633a61df83dd8206e780f67c85dd3403902f00f2
This commit is contained in:
Alexandre Bourdin 2021-10-05 15:38:53 +02:00 committed by Copybot
parent 4cecc6383a
commit 98db86b8f0
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/web/app/src/Features/BetaProgram/BetaProgramHandler.js
View file

@ -1,10 +1,12 @@
const { callbackify } = require('util') const { callbackify } = require('util')
const metrics = require('@overleaf/metrics') const metrics = require('@overleaf/metrics')
const UserUpdater = require('../User/UserUpdater') const UserUpdater = require('../User/UserUpdater')
const AnalyticsManager = require('../Analytics/AnalyticsManager')
async function optIn(userId) { async function optIn(userId) {
await UserUpdater.promises.updateUser(userId, { $set: { betaProgram: true } }) await UserUpdater.promises.updateUser(userId, { $set: { betaProgram: true } })
metrics.inc('beta-program.opt-in') metrics.inc('beta-program.opt-in')
AnalyticsManager.setUserPropertyForUser(userId, 'beta-program', true)
} }
async function optOut(userId) { async function optOut(userId) {
@ -12,6 +14,7 @@ async function optOut(userId) {
$set: { betaProgram: false }, $set: { betaProgram: false },
}) })
metrics.inc('beta-program.opt-out') metrics.inc('beta-program.opt-out')
AnalyticsManager.setUserPropertyForUser(userId, 'beta-program', false)
} }
const BetaProgramHandler = { const BetaProgramHandler = {

29
services/web/test/unit/src/BetaProgram/BetaProgramHandlerTests.js
View file

@ -27,6 +27,9 @@ describe('BetaProgramHandler', function () {
updateUser: sinon.stub().resolves(), updateUser: sinon.stub().resolves(),
}, },
}), }),
'../Analytics/AnalyticsManager': (this.AnalyticsManager = {
setUserPropertyForUser: sinon.stub().resolves(),
}),
}, },
}) })
}) })
@ -47,6 +50,19 @@ describe('BetaProgramHandler', function () {
}) })
}) })
it('should set beta-program user property to true', function (done) {
this.call(err => {
expect(err).to.not.exist
sinon.assert.calledWith(
this.AnalyticsManager.setUserPropertyForUser,
this.user_id,
'beta-program',
true
)
done()
})
})
it('should not produce an error', function (done) { it('should not produce an error', function (done) {
this.call(err => { this.call(err => {
expect(err).to.not.exist expect(err).to.not.exist
@ -85,6 +101,19 @@ describe('BetaProgramHandler', function () {
}) })
}) })
it('should set beta-program user property to false', function (done) {
this.call(err => {
expect(err).to.not.exist
sinon.assert.calledWith(
this.AnalyticsManager.setUserPropertyForUser,
this.user_id,
'beta-program',
false
)
done()
})
})
it('should not produce an error', function (done) { it('should not produce an error', function (done) {
this.call(err => { this.call(err => {
expect(err).to.not.exist expect(err).to.not.exist