github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #14793 from overleaf/jel-new-alert-content-string

Browse source 
[web] Option to pass content as string to notification component

GitOrigin-RevId: 05196a44d25dab5ba85b58965c3bb5ac071a3897
This commit is contained in:
Jessica Lawshe 2023-09-13 07:33:14 -05:00 committed by Copybot
parent a3c54c7369
commit 98c8ee0e1f
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/shared/components/notification.tsx
View file

@ -8,7 +8,7 @@ type NotificationType = 'info' | 'success' | 'warning' | 'error'
type NotificationProps = {
action?: React.ReactElement
ariaLive?: 'polite' | 'off' | 'assertive'
content: React.ReactElement
content: React.ReactElement | string
customIcon?: React.ReactElement
isDismissible?: boolean
isActionBelowContent?: boolean

4
services/web/frontend/stories/notification.stories.tsx
View file

@ -300,6 +300,10 @@ export const SuccessFlow = (args: Args) => {
return startNotification
}
export const ContentAsAString = (args: Args) => {
return <Notification {...args} content="An alert" />
}
export default {
title: 'Shared / Components / Notification',
component: Notification,

10
services/web/test/frontend/shared/components/notification.test.tsx
View file

@ -41,7 +41,7 @@ describe('<Notification />', function () {
screen.getByRole('button', { name: 'Close' })
})
it('renders with title', function () {
it('renders with title and content passed as HTML', function () {
render(
<Notification
type="info"
@ -50,5 +50,13 @@ describe('<Notification />', function () {
/>
)
screen.getByText('A title')
screen.getByText('A notification')
})
it('renders with content when passed as a string', function () {
render(
<Notification type="info" content="A notification" title="A title" />
)
screen.getByText('A notification')
})
})