github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #19818 from overleaf/ab-fix-split-test-archived-notification-comment

Browse source 
[web] Skip sending last versions comment with archived test notification

GitOrigin-RevId: 997111220161eaf7588cac8809024ac4a09bc037
This commit is contained in:
Alexandre Bourdin 2024-08-08 14:29:47 +02:00 committed by Copybot
parent b1cfb00e30
commit 972fbb7c67
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/web/app/src/Features/SplitTests/SlackNotificationManager.js
View file

@ -30,6 +30,10 @@ async function sendNotification(splitTest, action, user) {
].join('\n') ].join('\n')
const date = splitTest.archived ? splitTest.archivedAt : lastVersion.createdAt const date = splitTest.archived ? splitTest.archivedAt : lastVersion.createdAt
const comment =
action !== 'archived' && lastVersion.comment
? `with comment: ${lastVersion.comment}`
: ''
const payload = { const payload = {
name: splitTest.name, name: splitTest.name,
@ -41,7 +45,7 @@ async function sendNotification(splitTest, action, user) {
active: lastVersion.active.toString(), active: lastVersion.active.toString(),
author: user.email, author: user.email,
date: moment(date).utc().format('Do MMM YYYY, h:mm a') + ' UTC', date: moment(date).utc().format('Do MMM YYYY, h:mm a') + ' UTC',
comment: lastVersion.comment ? `with comment: ${lastVersion.comment}` : '', comment,
versionNumber: `${lastVersion.versionNumber}`, versionNumber: `${lastVersion.versionNumber}`,
url: `${Settings.siteUrl}/admin/split-test/edit/${splitTest.name}`, url: `${Settings.siteUrl}/admin/split-test/edit/${splitTest.name}`,
} }