github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #9009 from overleaf/ab-split-tests-saas-check

Browse source 
[web] Skip split test assignment logic when not in SaaS mode

GitOrigin-RevId: 4c370bbc78c5a6828207f3336dfa6af9f4d71e17
This commit is contained in:
Timothée Alby 2022-07-28 11:21:36 +02:00 committed by Copybot
parent b44bf48282
commit 95a289b80b
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
services/web/app/src/Features/SplitTests/SplitTestHandler.js
View file

@ -9,6 +9,7 @@ const SplitTestCache = require('./SplitTestCache')
const { SplitTest } = require('../../models/SplitTest')
const UserAnalyticsIdCache = require('../Analytics/UserAnalyticsIdCache')
const { getAnalyticsIdFromMongoUser } = require('../Analytics/AnalyticsHelper')
const Features = require('../../infrastructure/Features')
const DEFAULT_VARIANT = 'default'
const ALPHA_PHASE = 'alpha'
@ -46,6 +47,10 @@ const DEFAULT_ASSIGNMENT = {
* @returns {Promise<{variant: string, analytics: {segmentation: {splitTest: string, variant: string, phase: string, versionNumber: number}|{}}}>}
*/
async function getAssignment(req, res, splitTestName, { sync = false } = {}) {
if (!Features.hasFeature('saas')) {
return DEFAULT_ASSIGNMENT
}
const query = req.query || {}
let assignment
@ -100,6 +105,10 @@ async function getAssignmentForUser(
splitTestName,
{ sync = false } = {}
) {
if (!Features.hasFeature('saas')) {
return DEFAULT_ASSIGNMENT
}
const analyticsId = await UserAnalyticsIdCache.get(userId)
return _getAssignment(splitTestName, { analyticsId, userId, sync })
}
@ -120,6 +129,10 @@ async function getAssignmentForMongoUser(
splitTestName,
{ sync = false } = {}
) {
if (!Features.hasFeature('saas')) {
return DEFAULT_ASSIGNMENT
}
return _getAssignment(splitTestName, {
analyticsId: getAnalyticsIdFromMongoUser(user),
sync,
@ -132,6 +145,10 @@ async function getAssignmentForMongoUser(
* Get a mapping of the active split test assignments for the given user
*/
async function getActiveAssignmentsForUser(userId) {
if (!Features.hasFeature('saas')) {
return {}
}
const user = await _getUser(userId)
if (user == null) {
return {}

5
services/web/test/acceptance/src/PrimaryEmailCheckTests.js
View file

@ -2,6 +2,7 @@ const UserHelper = require('./helpers/UserHelper')
const Settings = require('@overleaf/settings')
const { expect } = require('chai')
const SplitTestManager = require('../../../app/src/Features/SplitTests/SplitTestManager')
const Features = require('../../../app/src/infrastructure/Features')
// While the split test is in progress this must be appended to URLs during tests
const SPLIT_TEST_QUERY = '?primary-email-check=active'
@ -12,6 +13,10 @@ describe('PrimaryEmailCheck', function () {
// Create the primary-email-check split test because this is now required for the query string override to work. See
// https://github.com/overleaf/internal/pull/7545#discussion_r848575736
before(async function () {
if (!Features.hasFeature('saas')) {
this.skip()
}
await SplitTestManager.createSplitTest({
name: 'primary-email-check',
configuration: {