Merge pull request #3273 from overleaf/as-fix-institution-script-error-handling

Handle error in check institution script correctly

GitOrigin-RevId: 5e6bee330020a9c675779e451853dc3cbf4d6324
This commit is contained in:
Alasdair Smith 2020-10-09 11:48:37 +01:00 committed by Copybot
parent 346cdd16d4
commit 941241af54

View file

@ -9,6 +9,7 @@ const NotificationsBuilder = require('../Notifications/NotificationsBuilder')
const SubscriptionLocator = require('../Subscription/SubscriptionLocator')
const { Institution } = require('../../models/Institution')
const { Subscription } = require('../../models/Subscription')
const OError = require('@overleaf/o-error')
const ASYNC_LIMIT = parseInt(process.env.ASYNC_LIMIT, 10) || 5
module.exports = {
@ -39,7 +40,10 @@ module.exports = {
UserGetter.getUsersByAnyConfirmedEmail(
affiliations.map(affiliation => affiliation.email),
{ features: 1, samlIdentifiers: 1 },
(error, users) => callback(error, checkFeatures(institutionId, users))
(error, users) => {
if (error) return callback(OError.tag(error))
callback(error, checkFeatures(institutionId, users))
}
)
})
},