github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3370 from overleaf/jpa-replace-count

Browse source 
[misc] replace mongo .count queries

GitOrigin-RevId: 7963286b4d84d1f03978f3212e92bb491eec6b74
This commit is contained in:
Simon Detheridge 2020-11-09 10:35:57 +00:00 committed by Copybot
parent 6a3e697396
commit 94092c905b
3 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/src/Features/Collaborators/CollaboratorsInviteHandler.js
View file

@ -51,7 +51,7 @@ const CollaboratorsInviteHandler = {
callback = function(err, count) {}
}
logger.log({ projectId }, 'counting invites for project')
return ProjectInvite.count({ projectId }, function(err, count) {
return ProjectInvite.countDocuments({ projectId }, function(err, count) {
if (err != null) {
OError.tag(err, 'error getting invites from mongo', {
projectId

2
services/web/test/acceptance/src/ModelTests.js
View file

@ -18,7 +18,7 @@ describe('mongoose', function() {
it('does not allow the creation of multiple users with the same email', async function() {
await expect(User.create({ email: email })).to.be.fulfilled
await expect(User.create({ email: email })).to.be.rejected
await expect(User.count({ email: email })).to.eventually.equal(1)
await expect(User.countDocuments({ email: email })).to.eventually.equal(1)
})
})

11
services/web/test/unit/src/Collaborators/CollaboratorsInviteHandlerTests.js
View file

@ -35,7 +35,7 @@ describe('CollaboratorsInviteHandler', function() {
this.findOne = sinon.stub()
this.find = sinon.stub()
this.deleteOne = sinon.stub()
this.count = sinon.stub()
this.countDocuments = sinon.stub()
}
constructor(options) {
if (options == null) {
@ -105,7 +105,7 @@ describe('CollaboratorsInviteHandler', function() {
describe('getInviteCount', function() {
beforeEach(function() {
this.ProjectInvite.count.callsArgWith(1, null, 2)
this.ProjectInvite.countDocuments.callsArgWith(1, null, 2)
return (this.call = callback => {
return this.CollaboratorsInviteHandler.getInviteCount(
this.projectId,
@ -129,9 +129,12 @@ describe('CollaboratorsInviteHandler', function() {
})
})
describe('when model.count produces an error', function() {
describe('when model.countDocuments produces an error', function() {
beforeEach(function() {
return this.ProjectInvite.count.callsArgWith(1, new Error('woops'))
return this.ProjectInvite.countDocuments.callsArgWith(
1,
new Error('woops')
)
})
it('should produce an error', function(done) {