github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Ensure that tracked changes are highlighted in read-only mode (#18036)

Browse source 
GitOrigin-RevId: 5010e1649d8f15014f9c8ef578073be7c6545aa4
This commit is contained in:
Alf Eaton 2024-04-23 09:30:53 +01:00 committed by Copybot
parent 98cefaa5bd
commit 905c9b2c28
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
services/web/frontend/js/features/ide-react/context/review-panel/hooks/use-review-panel-state.ts
View file

@ -428,17 +428,15 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
let localResolvedThreadIds = resolvedThreadIds
if (!isRestrictedTokenMember) {
if (rangesTracker.comments.length > 0) {
const threadsLoadResult = await ensureThreadsAreLoaded()
if (threadsLoadResult?.resolvedThreadIds) {
localResolvedThreadIds = threadsLoadResult.resolvedThreadIds
}
} else if (loadingThreads) {
// ensure that tracked changes are highlighted even if no comments are loaded
setLoadingThreads(false)
dispatchReviewPanelEvent('loaded_threads')
if (!isRestrictedTokenMember && rangesTracker.comments.length > 0) {
const threadsLoadResult = await ensureThreadsAreLoaded()
if (threadsLoadResult?.resolvedThreadIds) {
localResolvedThreadIds = threadsLoadResult.resolvedThreadIds
}
} else if (loadingThreads) {
// ensure that tracked changes are highlighted even if no comments are loaded
setLoadingThreads(false)
dispatchReviewPanelEvent('loaded_threads')
}
if (!loadingThreadsInProgressRef.current) {