From 8ffec68250aa6fc0e0105f89ef95c5e047df94a7 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Mon, 5 Sep 2016 12:35:49 +0100 Subject: [PATCH] add comment about fallback case --- services/real-time/app/coffee/WebsocketController.coffee | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/real-time/app/coffee/WebsocketController.coffee b/services/real-time/app/coffee/WebsocketController.coffee index 0f04981d05..d2aef5b424 100644 --- a/services/real-time/app/coffee/WebsocketController.coffee +++ b/services/real-time/app/coffee/WebsocketController.coffee @@ -101,7 +101,10 @@ module.exports = WebsocketController = Utils.getClientAttributes client, ["project_id", "user_id"], (error, {project_id, user_id}) -> logger.log {user_id, project_id, doc_id, client_id: client.id}, "client leaving doc" client.leave doc_id - AuthorizationManager.removeAccessToDoc client, doc_id # may not be needed, could block updates? + # we could remove permission when user leaves a doc, but because + # the connection is per-project, we continue to allow access + # after the initial joinDoc since we know they are already authorised. + ## AuthorizationManager.removeAccessToDoc client, doc_id callback() updateClientPosition: (client, cursorData, callback = (error) ->) ->