Merge commit 'ab16aa9'

This commit is contained in:
James Allen 2017-03-09 11:36:22 +00:00
commit 8f434cdd8b
6 changed files with 17 additions and 15 deletions

View file

@ -224,6 +224,11 @@ module.exports = ProjectController =
cb = underscore.once(cb) cb = underscore.once(cb)
if !user_id? if !user_id?
return cb() return cb()
timestamp = user_id.toString().substring(0,8)
userSignupDate = new Date( parseInt( timestamp, 16 ) * 1000 )
if userSignupDate > new Date("2017-03-09") # 8th March
# Don't show for users who registered after it was released
return cb(null, false)
timeout = setTimeout cb, 500 timeout = setTimeout cb, 500
AnalyticsManager.getLastOccurance user_id, "shown-track-changes-onboarding-2", (error, event) -> AnalyticsManager.getLastOccurance user_id, "shown-track-changes-onboarding-2", (error, event) ->
clearTimeout timeout clearTimeout timeout

View file

@ -22,11 +22,6 @@ module.exports = ProjectEditorHandler =
if !result.invites? if !result.invites?
result.invites = [] result.invites = []
trackChangesVisible = false
for member in members
if member.privilegeLevel == "owner" and (member.user?.featureSwitches?.track_changes or member.user?.betaProgram)
trackChangesVisible = true
{owner, ownerFeatures, members} = @buildOwnerAndMembersViews(members) {owner, ownerFeatures, members} = @buildOwnerAndMembersViews(members)
result.owner = owner result.owner = owner
result.members = members result.members = members
@ -40,7 +35,7 @@ module.exports = ProjectEditorHandler =
templates: false templates: false
references: false references: false
trackChanges: false trackChanges: false
trackChangesVisible: ProjectEditorHandler.trackChangesAvailable and trackChangesVisible trackChangesVisible: ProjectEditorHandler.trackChangesAvailable
}) })
return result return result

View file

@ -39,9 +39,6 @@ UserSchema = new Schema
references: { type:Boolean, default: Settings.defaultFeatures.references } references: { type:Boolean, default: Settings.defaultFeatures.references }
trackChanges: { type:Boolean, default: Settings.defaultFeatures.trackChanges } trackChanges: { type:Boolean, default: Settings.defaultFeatures.trackChanges }
} }
featureSwitches : {
track_changes: { type: Boolean }
}
referal_id : {type:String, default:() -> uuid.v4().split("-")[0]} referal_id : {type:String, default:() -> uuid.v4().split("-")[0]}
refered_users: [ type:ObjectId, ref:'User' ] refered_users: [ type:ObjectId, ref:'User' ]
refered_user_count: { type:Number, default: 0 } refered_user_count: { type:Number, default: 0 }

View file

@ -18,9 +18,7 @@ block content
| #{translate("beta_program_badge_description")} | #{translate("beta_program_badge_description")}
span.beta-feature-badge span.beta-feature-badge
p.text-centered p.text-centered
strong We're currently testing track changes and commenting: strong We're not currently testing anything in beta, but keep checking back!
p.text-centered
img(src="/img/teasers/track-changes/track-changes-beta.png", style="max-width: 100%; border-bottom: 1px solid #ddd")
.row.text-centered .row.text-centered
.col-md-12 .col-md-12
if user.betaProgram if user.betaProgram

View file

@ -94,7 +94,6 @@ header.toolbar.toolbar-header.toolbar-with-labels(
i.review-icon i.review-icon
p.toolbar-label p.toolbar-label
| #{translate("review")} | #{translate("review")}
span(style="vertical-align: 20%; margin-left: 4px; padding: 2px 4px;").beta-feature-badge
a.btn.btn-full-height( a.btn.btn-full-height(
href, href,
ng-if="permissions.admin", ng-if="permissions.admin",

View file

@ -13,7 +13,7 @@ describe "ProjectController", ->
@project_id = "123213jlkj9kdlsaj" @project_id = "123213jlkj9kdlsaj"
@user = @user =
_id:"!£123213kjljkl" _id:"588f3ddae8ebc1bac07c9fa4"
first_name: "bjkdsjfk" first_name: "bjkdsjfk"
@settings = @settings =
apis: apis:
@ -302,7 +302,7 @@ describe "ProjectController", ->
name:"my proj" name:"my proj"
_id:"213123kjlkj" _id:"213123kjlkj"
@user = @user =
_id:"123kj21k3lj" _id: "588f3ddae8ebc1bac07c9fa4"
ace: ace:
fontSize:"massive" fontSize:"massive"
theme:"sexy" theme:"sexy"
@ -381,3 +381,11 @@ describe "ProjectController", ->
opts.showTrackChangesOnboarding.should.equal false opts.showTrackChangesOnboarding.should.equal false
done() done()
@ProjectController.loadEditor @req, @res @ProjectController.loadEditor @req, @res
it "should set showTrackChangesOnboarding = false if the user signed up after release", (done) ->
@AuthenticationController.getLoggedInUserId.returns("58c11a608ba0d6e49e8ce5d5")
@AnalyticsManager.getLastOccurance.yields(null, null)
@res.render = (pageName, opts)=>
opts.showTrackChangesOnboarding.should.equal false
done()
@ProjectController.loadEditor @req, @res