From 8abf3593fb4e3218c2e69bece0365f0a11aa2bfb Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Mon, 12 Mar 2018 13:36:16 +0000 Subject: [PATCH] Prevent CM/Sharejs adapter from overwriting value in editor --- .../public/coffee/ide/editor/sharejs/vendor/client/cm.coffee | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/services/web/public/coffee/ide/editor/sharejs/vendor/client/cm.coffee b/services/web/public/coffee/ide/editor/sharejs/vendor/client/cm.coffee index 7715beccc1..b6ea0ede63 100644 --- a/services/web/public/coffee/ide/editor/sharejs/vendor/client/cm.coffee +++ b/services/web/public/coffee/ide/editor/sharejs/vendor/client/cm.coffee @@ -36,8 +36,9 @@ window.sharejs.extendDoc 'attach_cm', (editor, keepEditorContents) -> console.error "Text does not match!" console.error "editor: #{editorText}" console.error "ot: #{otText}" - # Replace the editor text with the doc snapshot. - editor.setValue sharedoc.getText() + # Removed editor.setValue here as it would cause recursive loops if + # consistency check failed - because setting the value would trigger + # the change event , 0 if keepEditorContents