Merge pull request #221 from overleaf/jpa-explicit-dependencies

[misc] add linting for missing explicit dependencies and fix any errors
This commit is contained in:
Jakob Ackermann 2021-06-15 10:09:43 +02:00 committed by GitHub
commit 878cea8087
3 changed files with 13 additions and 4 deletions

View file

@ -22,7 +22,10 @@
"rules": {
// Swap the no-unused-expressions rule with a more chai-friendly one
"no-unused-expressions": 0,
"chai-friendly/no-unused-expressions": "error"
"chai-friendly/no-unused-expressions": "error",
// Do not allow importing of implicit dependencies.
"import/no-extraneous-dependencies": "error"
},
"overrides": [
{
@ -57,7 +60,13 @@
"files": ["app/**/*.js", "app.js", "index.js"],
"rules": {
// don't allow console.log in backend code
"no-console": "error"
"no-console": "error",
// Do not allow importing of implicit dependencies.
"import/no-extraneous-dependencies": ["error", {
// Do not allow importing of devDependencies.
"devDependencies": false
}]
}
}
]

View file

@ -15,7 +15,7 @@
*/
let CommandRunner
const { spawn } = require('child_process')
const _ = require('underscore')
const _ = require('lodash')
const logger = require('logger-sharelatex')
logger.info('using standard command runner')

View file

@ -6,4 +6,4 @@ clsi
--env-pass-through=TEXLIVE_IMAGE
--node-version=12.21.0
--public-repo=True
--script-version=3.7.0
--script-version=3.8.0