From 8227e68acaa6391f5f99e5eb88828da0a8b0a86c Mon Sep 17 00:00:00 2001
From: Alf Eaton <75253002+aeaton-overleaf@users.noreply.github.com>
Date: Wed, 31 Mar 2021 11:44:48 +0100
Subject: [PATCH] Improve form "for" and "autocomplete" attributes (#3822)

GitOrigin-RevId: 2ce35d57526fc36b5a974d0f940ef6ba08806864
---
 services/web/app/views/user/passwordReset.pug | 3 ++-
 services/web/app/views/user/setPassword.pug   | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/services/web/app/views/user/passwordReset.pug b/services/web/app/views/user/passwordReset.pug
index b99d67e416..38c9922ba7 100644
--- a/services/web/app/views/user/passwordReset.pug
+++ b/services/web/app/views/user/passwordReset.pug
@@ -23,11 +23,12 @@ block content
 							form-messages(for="passwordResetForm" role="alert")
 							.form-group
 								label(for='email') #{translate("please_enter_email")}
-								input.form-control(
+								input.form-control#email(
 									type='email',
 									name='email',
 									placeholder='email@example.com',
 									required,
+									autocomplete="username",
 									ng-model="email",
 									autofocus
 								)
diff --git a/services/web/app/views/user/setPassword.pug b/services/web/app/views/user/setPassword.pug
index 60009bec48..554030731a 100644
--- a/services/web/app/views/user/setPassword.pug
+++ b/services/web/app/views/user/setPassword.pug
@@ -42,6 +42,7 @@ block content
 									name='password',
 									placeholder='new password',
 									required,
+									autocomplete="new-password",
 									ng-model="password",
 									autofocus,
 									complex-password