From 8144d431a62c569bc830a0df93ab7f330f309151 Mon Sep 17 00:00:00 2001 From: Tim Down <158919+timdown@users.noreply.github.com> Date: Mon, 6 Nov 2023 13:08:52 +0000 Subject: [PATCH] Merge pull request #15597 from overleaf/td-ide-page-preview-pdf-fix Remove FileTreeManager from FileViewPdf GitOrigin-RevId: ca58d8695ab8e8868f8025aab932d665742a4131 --- .../features/file-view/components/file-view-pdf.tsx | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx b/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx index 2a613d2762..12be147a72 100644 --- a/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx +++ b/services/web/frontend/js/features/file-view/components/file-view-pdf.tsx @@ -1,7 +1,6 @@ import { FC, useCallback } from 'react' import useIsMounted from '@/shared/hooks/use-is-mounted' import { useFileTreePathContext } from '@/features/file-tree/contexts/file-tree-path' -import { useIdeContext } from '@/shared/context/ide-context' import { debugConsole } from '@/utils/debugging' const FileViewPdf: FC<{ @@ -11,8 +10,7 @@ const FileViewPdf: FC<{ }> = ({ fileId, onLoad, onError }) => { const mountedRef = useIsMounted() - const { fileTreeManager } = useIdeContext() - const { previewByPath } = useFileTreePathContext() + const { previewByPath, pathInFolder } = useFileTreePathContext() const handleContainer = useCallback( async (element: HTMLDivElement | null) => { @@ -27,9 +25,8 @@ const FileViewPdf: FC<{ return } - const entity = fileTreeManager.findEntityById(fileId) - const path = fileTreeManager.getEntityPath(entity) - const preview = previewByPath(path) + const path = pathInFolder(fileId) + const preview = path ? previewByPath(path) : null if (!preview) { onError() @@ -61,7 +58,7 @@ const FileViewPdf: FC<{ } } }, - [fileTreeManager, mountedRef, previewByPath, fileId, onLoad, onError] + [mountedRef, pathInFolder, fileId, previewByPath, onLoad, onError] ) return