From 811706167441cf5487020917e00bb083c7183177 Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Thu, 8 Feb 2018 13:04:47 +0000 Subject: [PATCH] Make the retry-on-fail behaviour optional --- .../web/app/coffee/Features/Analytics/AnalyticsManager.coffee | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee b/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee index a1056481d6..1cd187f1ac 100644 --- a/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee +++ b/services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee @@ -14,7 +14,7 @@ makeRequest = (opts, callback)-> _go = () -> request opts, (err, response, data) -> if err? - if iteration == retryTimings.length + if iteration == retryTimings.length or !opts.retryOnFail logger.err {err, url: opts.url}, "Error in analytics request, retries failed" return callback(err) @@ -51,6 +51,7 @@ module.exports = method:"POST" timeout:1000 url: "/user/#{user_id}/event" + retryOnFail: true if settings.overleaf? opts.qs = {fromV2: 1} makeRequest opts, callback @@ -68,6 +69,7 @@ module.exports = qs: userId: userId projectId: projectId + retryOnFail: true if settings.overleaf? opts.qs.fromV2 = 1 makeRequest opts, callback