github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-23 13:21:37 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix double callback for proc.on 'error' and proc.on 'close'

Browse source
This commit is contained in:
Brian Gough 2015-02-27 16:07:02 +00:00
parent 140090da47
commit 7f38c5e5a3
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
services/clsi/app/coffee/OutputFileOptimiser.coffee
View file

@ -2,6 +2,7 @@ fs = require "fs"
Path = require "path"
spawn = require("child_process").spawn
logger = require "logger-sharelatex"
_ = require "underscore"
module.exports = OutputFileOptimiser =
@ -22,12 +23,15 @@ module.exports = OutputFileOptimiser =
stdout = ""
proc.stdout.on "data", (chunk) ->
stdout += chunk.toString()
proc.on "error", callback
callback = _.once(callback) # avoid double call back for error and close event
proc.on "error", (err) ->
logger.warn {err, args}, "qpdf failed"
callback(null) # ignore the error
proc.on "close", (code) ->
if code != 0
logger.warn {directory, code}, "qpdf returned error"
return callback null
logger.warn {code, args}, "qpdf returned error"
return callback(null) # ignore the error
fs.rename tmpOutput, dst, (err) ->
if err?
logger.warn {tmpOutput, dst}, "failed to rename output of qpdf command"
callback err
callback(null) # ignore the error