github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #12870 from overleaf/td-history-prevent-diff-render-on-label-change

Browse source 
History migration: prevent unnecessary render when adding or deleting a label

GitOrigin-RevId: acabd581403f17f863e3bd0c06d1fbd77fe22228
This commit is contained in:
Tim Down 2023-05-02 15:17:00 +01:00 committed by Copybot
parent 76103eb77f
commit 7f17992cbc
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/web/frontend/js/features/history/context/history-context.tsx
View file

@ -187,12 +187,13 @@ function useHistory() {
} }
}, [view, fetchNextBatchOfUpdates]) }, [view, fetchNextBatchOfUpdates])
const { updateRange, comparing } = selection const { updateRange, comparing, files } = selection
const { updates } = updatesInfo const { updates } = updatesInfo
const filesEmpty = files.length === 0
// Load files when the update selection changes // Load files when the update selection changes
useEffect(() => { useEffect(() => {
if (!updateRange) { if (!updateRange || !filesEmpty) {
return return
} }
const { fromV, toV } = updateRange const { fromV, toV } = updateRange
@ -222,7 +223,7 @@ function useHistory() {
.catch(error => { .catch(error => {
setError(error) setError(error)
}) })
}, [updateRange, projectId, updates, comparing, setError]) }, [updateRange, projectId, updates, comparing, setError, filesEmpty])
useEffect(() => { useEffect(() => {
// Set update range if there isn't one and updates have loaded // Set update range if there isn't one and updates have loaded