Merge pull request #1414 from sharelatex/as-fix-pdf-link-referrer

Fix links in PDF to have noreferrer

GitOrigin-RevId: fa14e552b0d4947781c88ce22fc70696b04cf8a4

services/web/public/src/ide/pdfng/directives/pdfAnnotations.js

@@ -1,87 +1,63 @@
-/* eslint-disable
+/* global PDFJS */
-    max-len,
-    no-return-assign,
-    no-undef,
-    no-unreachable,
-*/
-// TODO: This file was created by bulk-decaffeinate.
-// Fix any style issues and re-enable lint.
-/*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * DS102: Remove unnecessary code created because of implicit returns
- * DS205: Consider reworking code to avoid use of IIFEs
- * DS206: Consider reworking classes to avoid initClass
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
-define(['base'], App =>
-  // App = angular.module 'pdfAnnotations', []
-  App.factory('pdfAnnotations', [
-    function() {
-      let pdfAnnotations
-      return (pdfAnnotations = (function() {
-        pdfAnnotations = class pdfAnnotations {
-          static initClass() {
-            this.EXTERNAL_LINK_TARGET = '_blank'
-          }
 
-          constructor(options) {
+define(['base'], App => {
-            this.annotationsLayerDiv = options.annotations
+  const EXTERNAL_LINK_TARGET = '_blank'
-            this.viewport = options.viewport
+  const REL_NOOPENER = 'noreferrer noopener'
-            this.navigateFn = options.navigateFn
-          }
 
-          setAnnotations(annotations) {
+  App.factory('pdfAnnotations', function() {
-            return (() => {
+    class pdfAnnotations {
-              const result = []
+      constructor(options) {
-              for (let annotation of Array.from(annotations)) {
+        this.annotationsLayerDiv = options.annotations
-                switch (annotation.subtype) {
+        this.viewport = options.viewport
-                  case 'Link':
+        this.navigateFn = options.navigateFn
-                    result.push(this.addLink(annotation))
+      }
-                    break
-                  case 'Text':
-                    continue
-                    break
-                  default:
-                    result.push(undefined)
-                }
-              }
-              return result
-            })()
-          }
 
-          addLink(link) {
+      setAnnotations(annotations) {
-            const element = this.buildLinkElementFromRect(link.rect)
+        const result = []
-            this.setLinkTarget(element, link)
+        for (let annotation of annotations) {
-            return this.annotationsLayerDiv.appendChild(element)
+          switch (annotation.subtype) {
-          }
+            case 'Link':
-
+              result.push(this.addLink(annotation))
-          buildLinkElementFromRect(rect) {
+              break
-            rect = this.viewport.convertToViewportRectangle(rect)
+            case 'Text':
-            rect = PDFJS.Util.normalizeRect(rect)
+              continue
-            const element = document.createElement('a')
+            default:
-            element.style.left = Math.floor(rect[0]) + 'px'
+              result.push(undefined)
-            element.style.top = Math.floor(rect[1]) + 'px'
-            element.style.width = Math.ceil(rect[2] - rect[0]) + 'px'
-            element.style.height = Math.ceil(rect[3] - rect[1]) + 'px'
-            return element
-          }
-
-          setLinkTarget(element, link) {
-            if (link.url) {
-              element.href = link.url
-              return (element.target = this.EXTERNAL_LINK_TARGET)
-            } else if (link.dest) {
-              element.href = `#${link.dest}`
-              return (element.onclick = e => {
-                this.navigateFn(link)
-                return false
-              })
-            }
           }
         }
-        pdfAnnotations.initClass()
+      }
-        return pdfAnnotations
+
-      })())
+      addLink(link) {
+        const element = this.buildLinkElementFromRect(link.rect)
+        this.setLinkTarget(element, link)
+        this.annotationsLayerDiv.appendChild(element)
+      }
+
+      buildLinkElementFromRect(rect) {
+        rect = this.viewport.convertToViewportRectangle(rect)
+        rect = PDFJS.Util.normalizeRect(rect)
+        const element = document.createElement('a')
+        element.style.left = Math.floor(rect[0]) + 'px'
+        element.style.top = Math.floor(rect[1]) + 'px'
+        element.style.width = Math.ceil(rect[2] - rect[0]) + 'px'
+        element.style.height = Math.ceil(rect[3] - rect[1]) + 'px'
+        return element
+      }
+
+      setLinkTarget(element, link) {
+        if (link.url) {
+          element.href = link.url
+          element.target = EXTERNAL_LINK_TARGET
+          element.rel = REL_NOOPENER
+        } else if (link.dest) {
+          element.href = `#${link.dest}`
+          element.onclick = () => {
+            this.navigateFn(link)
+            return false
+          }
+        }
+      }
     }
-  ]))
+    return pdfAnnotations
+  })
+})