From 7d0f1179185e97a193beae738fc61aec5e320cc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= Date: Mon, 19 Apr 2021 14:37:04 +0200 Subject: [PATCH] Merge pull request #3919 from overleaf/jpa-refactor-inline-script [views] referal/bonus: refactor inline script in event handler GitOrigin-RevId: 825f15c1badf964e0e0e2c9bc42951a5f318b357 --- services/web/app/views/referal/bonus.pug | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/web/app/views/referal/bonus.pug b/services/web/app/views/referal/bonus.pug index 9b80439a76..67c202c471 100644 --- a/services/web/app/views/referal/bonus.pug +++ b/services/web/app/views/referal/bonus.pug @@ -32,7 +32,7 @@ block content .row .col-md-8.col-md-offset-2.bonus-banner .title - a(href='#', onclick='postToFeed(); return false;').facebook + a(href='#').facebook i.fa.fa-fw.fa-2x.fa-facebook-square(aria-hidden="true") | | #{translate("post_on_facebook")} @@ -158,8 +158,10 @@ block append foot-scripts $(".email").click(function() { ga('send', 'event', 'referal-button', 'clicked', "email") }); - $(".facebook").click(function() { + $(".facebook").click(function(e) { ga('send', 'event', 'referal-button', 'clicked', "facebook") + postToFeed() + e.preventDefault() }); $(".link").click(function() { ga('send', 'event', 'referal-button', 'clicked', "direct-link")