github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ide-react] Only call scope watcher with the latest value from each batch (#16296)

Browse source 
GitOrigin-RevId: 0284f99130424d50a2115853d793979a2b0387ff
This commit is contained in:
Alf Eaton 2023-12-20 11:48:05 +00:00 committed by Copybot
parent fe206936ac
commit 7cb427738c
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/features/editor-navigation-toolbar/components/editor-navigation-toolbar-root.jsx
View file

@ -71,7 +71,7 @@ const EditorNavigationToolbarRoot = React.memo(
eventTracking.sendMB('navigation-clicked-chat', { eventTracking.sendMB('navigation-clicked-chat', {
action: isOpentoString(!chatIsOpen), action: isOpentoString(!chatIsOpen),
}) })
setChatIsOpen(value => !value) setChatIsOpen(!chatIsOpen)
}, [chatIsOpen, setChatIsOpen, markMessagesAsRead]) }, [chatIsOpen, setChatIsOpen, markMessagesAsRead])
const toggleReviewPanelOpen = useCallback( const toggleReviewPanelOpen = useCallback(

9
services/web/frontend/js/features/ide-react/scope-value-store/react-scope-value-store.ts
View file

@ -60,7 +60,7 @@ export class ReactScopeValueStore implements ScopeValueStore {
private readonly items = new Map<string, ScopeValueStoreValue>() private readonly items = new Map<string, ScopeValueStoreValue>()
private readonly persisters: Map<string, Persister> = new Map() private readonly persisters: Map<string, Persister> = new Map()
private watcherUpdates: WatcherUpdate[] = [] private watcherUpdates = new Map<string, WatcherUpdate>()
private watcherUpdateTimer: number | null = null private watcherUpdateTimer: number | null = null
private allowedNonExistentPaths: AllowedNonExistentPath[] = [] private allowedNonExistentPaths: AllowedNonExistentPath[] = []
@ -129,8 +129,8 @@ export class ReactScopeValueStore implements ScopeValueStore {
this.watcherUpdateTimer = null this.watcherUpdateTimer = null
} }
// Clone watcherUpdates in case a watcher creates new watcherUpdates // Clone watcherUpdates in case a watcher creates new watcherUpdates
const watcherUpdates = [...this.watcherUpdates] const watcherUpdates = [...this.watcherUpdates.values()]
this.watcherUpdates = [] this.watcherUpdates = new Map()
for (const { value, watchers } of watcherUpdates) { for (const { value, watchers } of watcherUpdates) {
for (const watcher of watchers) { for (const watcher of watchers) {
if (!watcher.removed) { if (!watcher.removed) {
@ -152,7 +152,7 @@ export class ReactScopeValueStore implements ScopeValueStore {
path, path,
watchers: [...watchers], watchers: [...watchers],
} }
this.watcherUpdates.push(update) this.watcherUpdates.set(path, update)
if (!this.watcherUpdateTimer) { if (!this.watcherUpdateTimer) {
this.watcherUpdateTimer = window.setTimeout(() => { this.watcherUpdateTimer = window.setTimeout(() => {
this.watcherUpdateTimer = null this.watcherUpdateTimer = null
@ -166,6 +166,7 @@ export class ReactScopeValueStore implements ScopeValueStore {
} }
private setValue<T>(path: string, value: T): void { private setValue<T>(path: string, value: T): void {
debugConsole.log('setValue', path, value)
let item = this.items.get(path) let item = this.items.get(path)
if (item === undefined) { if (item === undefined) {
item = { value, watchers: [] } item = { value, watchers: [] }