github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #15798 from overleaf/mj-features-page-teardown

Browse source 
[web] Tear down features-page split test

GitOrigin-RevId: 346064bea8775033d226f4405843717b380085fd
This commit is contained in:
Mathias Jakobsen 2023-11-20 10:24:16 +00:00 committed by Copybot
parent 9ca43ebc4e
commit 7c8014d791
16 changed files with 41 additions and 230 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/src/infrastructure/ExpressLocals.js
View file

@ -81,10 +81,7 @@ function getWebpackAssets(entrypoint, section) {
module.exports = function (webRouter, privateApiRouter, publicApiRouter) {
webRouter.use(
expressify(
SplitTestMiddleware.loadAssignmentsInLocals([
'design-system-updates',
'features-page',
])
SplitTestMiddleware.loadAssignmentsInLocals(['design-system-updates'])
)
)

7
services/web/app/views/layout/fat-footer.pug
View file

@ -1,5 +1,3 @@
- var featuresPageVariant = splitTestVariants && splitTestVariants['features-page']
footer.fat-footer.hidden-print
.fat-footer-container(role="navigation" aria-label=translate('footer_navigation'))
.fat-footer-sections(class=hideFatFooter ? 'hidden' : undefined)
@ -43,10 +41,7 @@ footer.fat-footer.hidden-print
ul.list-unstyled
li
if !featuresPageVariant || featuresPageVariant === 'default'
a(href="/learn/how-to/Overleaf_premium_features" event-tracking="features-page-link" event-tracking-mb="true" event-tracking-trigger="click" event-segmentation={splitTest: "features-page", splitTestVariant: "default", locationInPage: "footer"}) #{translate('premium_features')}
else
a(href="/about/features-overview" event-tracking="features-page-link" event-tracking-mb="true" event-tracking-trigger="click" event-segmentation={splitTest: "features-page", splitTestVariant: "new", locationInPage: "footer"}) #{translate('features')}
a(href="/learn/how-to/Overleaf_premium_features") #{translate('premium_features')}
li
a(href="/user/subscription/plans?itm_referrer=footer-for-indv-groups") !{translate('for_individuals_and_groups')}
li

2
services/web/app/views/layout/navbar-marketing.pug
View file

@ -30,7 +30,6 @@ nav.navbar.navbar-default.navbar-main
- var canDisplayAdminRedirect = canRedirectToAdminDomain()
- var canDisplaySplitTestMenu = hasFeature('saas') && (canDisplayAdminMenu || (getSessionUser() && getSessionUser().staffAccess && (getSessionUser().staffAccess.splitTestMetrics || getSessionUser().staffAccess.splitTestManagement)))
- var canDisplaySurveyMenu = hasFeature('saas') && canDisplayAdminMenu
- var featuresPageVariant = splitTestVariants && splitTestVariants['features-page']
if (typeof(suppressNavbarRight) == "undefined")
.navbar-collapse.collapse(data-ol-navbar-main-collapse)
@ -101,7 +100,6 @@ nav.navbar.navbar-default.navbar-main
else
li
if child.url
if !child.splitTest || child.splitTest && child.splitTest === 'features-page' && child.splitTestVariant === featuresPageVariant
a(
href=child.url,
class=child.class,

2
services/web/app/views/layout/navbar.pug
View file

@ -15,7 +15,6 @@ nav.navbar.navbar-default.navbar-main
- var canDisplayAdminRedirect = canRedirectToAdminDomain()
- var canDisplaySplitTestMenu = hasFeature('saas') && (canDisplayAdminMenu || (getSessionUser() && getSessionUser().staffAccess && (getSessionUser().staffAccess.splitTestMetrics || getSessionUser().staffAccess.splitTestManagement)))
- var canDisplaySurveyMenu = hasFeature('saas') && canDisplayAdminMenu
- var featuresPageVariant = splitTestVariants && splitTestVariants['features-page']
if (typeof(suppressNavbarRight) == "undefined")
.navbar-collapse.collapse(collapse="navCollapsed")
@ -76,7 +75,6 @@ nav.navbar.navbar-default.navbar-main
else
li
if child.url
if !child.splitTest || child.splitTest && child.splitTest === 'features-page' && child.splitTestVariant === featuresPageVariant
a(
href=child.url,
class=child.class,

1
services/web/frontend/extracted-translations.json
View file

@ -404,7 +404,6 @@
"get_collaborative_benefits": "",
"get_discounted_plan": "",
"get_most_subscription_by_checking_features": "",
"get_most_subscription_by_checking_premium_features": "",
"git": "",
"git_authentication_token": "",
"git_authentication_token_create_modal_info_1": "",

16
services/web/frontend/js/features/project-list/components/current-plan-widget/commons-plan.tsx
View file

@ -1,8 +1,6 @@
import { useTranslation, Trans } from 'react-i18next'
import { CommonsPlanSubscription } from '../../../../../../types/project/dashboard/subscription'
import Tooltip from '../../../../shared/components/tooltip'
import getMeta from '../../../../utils/meta'
import * as eventTracking from '../../../../infrastructure/event-tracking'
type CommonsPlanProps = Pick<
CommonsPlanSubscription,
@ -18,14 +16,6 @@ function CommonsPlan({
const currentPlanLabel = (
<Trans i18nKey="premium_plan_label" components={{ b: <strong /> }} />
)
const featuresPageVariant = getMeta('ol-splitTestVariants')?.['features-page']
function handleLinkClick() {
eventTracking.sendMB('features-page-link', {
splitTest: 'features-page',
splitTestVariant: featuresPageVariant,
})
}
return (
<>
@ -38,11 +28,7 @@ function CommonsPlan({
id="commons-plan"
overlayProps={{ placement: 'bottom' }}
>
<a
href={featuresPageURL}
className="current-plan-label hidden-xs"
onClick={handleLinkClick}
>
<a href={featuresPageURL} className="current-plan-label hidden-xs">
{currentPlanLabel} <span className="info-badge" />
</a>
</Tooltip>

6
services/web/frontend/js/features/project-list/components/current-plan-widget/current-plan-widget.tsx
View file

@ -20,11 +20,7 @@ function CurrentPlanWidget() {
const isGroupPlan = type === 'group'
const isCommonsPlan = type === 'commons'
const newFeaturesPageVariant =
getMeta('ol-splitTestVariants')?.['features-page'] === 'new'
const featuresPageURL = newFeaturesPageVariant
? '/about/features-overview'
: '/learn/how-to/Overleaf_premium_features'
const featuresPageURL = '/learn/how-to/Overleaf_premium_features'
let currentPlan

15
services/web/frontend/js/features/project-list/components/current-plan-widget/free-plan.tsx
View file

@ -3,7 +3,6 @@ import { Button } from 'react-bootstrap'
import { FreePlanSubscription } from '../../../../../../types/project/dashboard/subscription'
import Tooltip from '../../../../shared/components/tooltip'
import * as eventTracking from '../../../../infrastructure/event-tracking'
import getMeta from '../../../../utils/meta'
type FreePlanProps = Pick<FreePlanSubscription, 'featuresPageURL'>
@ -22,14 +21,6 @@ function FreePlan({ featuresPageURL }: FreePlanProps) {
})
}
const featuresPageVariant = getMeta('ol-splitTestVariants')?.['features-page']
function handleLinkClick() {
eventTracking.sendMB('features-page-link', {
splitTest: 'features-page',
splitTestVariant: featuresPageVariant,
})
}
return (
<>
<span className="current-plan-label visible-xs">{currentPlanLabel}</span>
@ -38,11 +29,7 @@ function FreePlan({ featuresPageURL }: FreePlanProps) {
id="free-plan"
overlayProps={{ placement: 'bottom' }}
>
<a
href={featuresPageURL}
className="current-plan-label hidden-xs"
onClick={handleLinkClick}
>
<a href={featuresPageURL} className="current-plan-label hidden-xs">
{currentPlanLabel} <span className="info-badge" />
</a>
</Tooltip>{' '}

16
services/web/frontend/js/features/project-list/components/current-plan-widget/group-plan.tsx
View file

@ -1,8 +1,6 @@
import { useTranslation, Trans } from 'react-i18next'
import { GroupPlanSubscription } from '../../../../../../types/project/dashboard/subscription'
import Tooltip from '../../../../shared/components/tooltip'
import getMeta from '../../../../utils/meta'
import * as eventTracking from '../../../../infrastructure/event-tracking'
type GroupPlanProps = Pick<
GroupPlanSubscription,
@ -33,14 +31,6 @@ function GroupPlan({
<Trans i18nKey="premium_plan_label" components={{ b: <strong /> }} />
)
const featuresPageVariant = getMeta('ol-splitTestVariants')?.['features-page']
function handleLinkClick() {
eventTracking.sendMB('features-page-link', {
splitTest: 'features-page',
splitTestVariant: featuresPageVariant,
})
}
return (
<>
<span className="current-plan-label visible-xs">{currentPlanLabel}</span>
@ -56,11 +46,7 @@ function GroupPlan({
id="group-plan"
overlayProps={{ placement: 'bottom' }}
>
<a
href={featuresPageURL}
className="current-plan-label hidden-xs"
onClick={handleLinkClick}
>
<a href={featuresPageURL} className="current-plan-label hidden-xs">
{currentPlanLabel} <span className="info-badge" />
</a>
</Tooltip>

16
services/web/frontend/js/features/project-list/components/current-plan-widget/individual-plan.tsx
View file

@ -1,8 +1,6 @@
import { useTranslation, Trans } from 'react-i18next'
import { IndividualPlanSubscription } from '../../../../../../types/project/dashboard/subscription'
import Tooltip from '../../../../shared/components/tooltip'
import getMeta from '../../../../utils/meta'
import * as eventTracking from '../../../../infrastructure/event-tracking'
type IndividualPlanProps = Pick<
IndividualPlanSubscription,
@ -32,14 +30,6 @@ function IndividualPlan({
<Trans i18nKey="premium_plan_label" components={{ b: <strong /> }} />
)
const featuresPageVariant = getMeta('ol-splitTestVariants')?.['features-page']
function handleLinkClick() {
eventTracking.sendMB('features-page-link', {
splitTest: 'features-page',
splitTestVariant: featuresPageVariant,
})
}
return (
<>
<span className="current-plan-label visible-xs">{currentPlanLabel}</span>
@ -48,11 +38,7 @@ function IndividualPlan({
id="individual-plan"
overlayProps={{ placement: 'bottom' }}
>
<a
href={featuresPageURL}
className="current-plan-label hidden-xs"
onClick={handleLinkClick}
>
<a href={featuresPageURL} className="current-plan-label hidden-xs">
{currentPlanLabel} <span className="info-badge" />
</a>
</Tooltip>

32
services/web/frontend/js/features/subscription/components/dashboard/premium-features-link.tsx
View file

@ -1,32 +1,12 @@
import { Trans } from 'react-i18next'
import getMeta from '../../../../utils/meta'
import * as eventTracking from '../../../../infrastructure/event-tracking'
function PremiumFeaturesLink() {
const featuresPageVariant =
getMeta('ol-splitTestVariants')?.['features-page'] || 'default'
function handleLinkClick() {
eventTracking.sendMB('features-page-link', {
splitTest: 'features-page',
splitTestVariant: featuresPageVariant,
})
}
const featuresPageLink = (
// translation adds content
// eslint-disable-next-line jsx-a11y/anchor-has-content
<a
href={
featuresPageVariant === 'new'
? '/about/features-overview'
: '/learn/how-to/Overleaf_premium_features'
}
onClick={handleLinkClick}
/>
<a href="/about/features-overview" />
)
if (featuresPageVariant === 'new') {
return (
<p>
<Trans
@ -37,14 +17,4 @@ function PremiumFeaturesLink() {
)
}
return (
<p>
<Trans
i18nKey="get_most_subscription_by_checking_premium_features"
components={[featuresPageLink]}
/>
</p>
)
}
export default PremiumFeaturesLink

1
services/web/locales/en.json
View file

@ -652,7 +652,6 @@
"get_in_touch_having_problems": "<a href=\"__link__\">Get in touch with support</a> if you’re having problems",
"get_involved": "Get involved",
"get_most_subscription_by_checking_features": "Get the most out of your __appName__ subscription by checking out <0>__appName__’s features</0>.",
"get_most_subscription_by_checking_premium_features": "Get the most out of your __appName__ subscription by checking out the list of <0>__appName__’s premium features</0>.",
"get_same_latex_setup": "With __appName__ you get the same LaTeX set-up wherever you go. By working with your colleagues and students on __appName__, you know that you’re not going to hit any version inconsistencies or package conflicts.",
"get_started_now": "Get started now",
"get_the_most_out_headline": "Get the most out of __appName__ with features such as:",

32
services/web/test/frontend/features/project-list/components/current-plan-widget.test.tsx
View file

@ -246,12 +246,7 @@ describe('<CurrentPlanWidget />', function () {
})
})
describe('features page split test', function () {
const variants = [
{ name: 'default', link: '/learn/how-to/Overleaf_premium_features' },
{ name: 'new', link: '/about/features-overview' },
]
describe('features page', function () {
const plans = [
{ type: 'free' },
{
@ -281,39 +276,22 @@ describe('<CurrentPlanWidget />', function () {
},
]
for (const variant of variants) {
describe(`${variant.name} variant`, function () {
beforeEach(function () {
window.metaAttributesCache.set('ol-splitTestVariants', {
'features-page': variant.name,
})
})
afterEach(function () {
window.metaAttributesCache.delete('ol-splitTestVariants')
})
for (const plan of plans) {
it(`links to ${variant.name} features page on ${plan.type} plan and sends analytics event`, function () {
it(`links to features page on ${plan.type} plan`, function () {
window.metaAttributesCache.set('ol-usersBestSubscription', {
...plan,
})
render(<CurrentPlanWidget />)
const links = screen.getAllByRole('link')
expect(links[0].getAttribute('href')).to.equal(variant.link)
expect(links[0].getAttribute('href')).to.equal(
'/learn/how-to/Overleaf_premium_features'
)
fireEvent.click(links[0])
expect(sendMBSpy).to.be.calledOnce
expect(sendMBSpy).calledWith('features-page-link', {
splitTest: 'features-page',
splitTestVariant: variant.name,
page: '/',
})
window.metaAttributesCache.delete('ol-usersBestSubscription')
})
}
})
}
})
})

62
services/web/test/frontend/features/subscription/components/dashboard/premium-features-link.test.tsx
View file

@ -1,62 +0,0 @@
import { expect } from 'chai'
import sinon from 'sinon'
import { fireEvent, render, screen, within } from '@testing-library/react'
import * as eventTracking from '../../../../../../frontend/js/infrastructure/event-tracking'
import PremiumFeaturesLink from '../../../../../../frontend/js/features/subscription/components/dashboard/premium-features-link'
import * as useLocationModule from '../../../../../../frontend/js/shared/hooks/use-location'
describe('<PremiumFeaturesLink />', function () {
const originalLocation = window.location
let sendMBSpy: sinon.SinonSpy
const variants = [
{ name: 'default', link: '/learn/how-to/Overleaf_premium_features' },
{ name: 'new', link: '/about/features-overview' },
]
beforeEach(function () {
window.metaAttributesCache = new Map()
sendMBSpy = sinon.spy(eventTracking, 'sendMB')
this.locationStub = sinon.stub(useLocationModule, 'useLocation').returns({
assign: sinon.stub(),
reload: sinon.stub(),
})
})
afterEach(function () {
window.metaAttributesCache = new Map()
sendMBSpy.restore()
this.locationStub.restore()
})
for (const variant of variants) {
describe(`${variant.name} variant`, function () {
beforeEach(function () {
window.metaAttributesCache.set('ol-splitTestVariants', {
'features-page': variant.name,
})
})
afterEach(function () {
window.metaAttributesCache.delete('ol-splitTestVariants')
})
it('renders the premium features link and sends analytics event', function () {
render(<PremiumFeaturesLink />)
const premiumText = screen.getByText('Get the most out of your', {
exact: false,
})
const link = within(premiumText).getByRole('link')
fireEvent.click(link)
expect(sendMBSpy).to.be.calledOnce
expect(sendMBSpy).calledWith('features-page-link', {
splitTest: 'features-page',
splitTestVariant: variant.name,
page: originalLocation.pathname,
})
})
})
}
})

2
services/web/test/frontend/features/subscription/components/dashboard/subscription-dashboard.test.tsx
View file

@ -33,7 +33,7 @@ describe('<SubscriptionDashboard />', function () {
it('renders the "Get the most out of your" subscription text', function () {
screen.getByText(
'Get the most out of your Overleaf subscription by checking out the list of',
'Get the most out of your Overleaf subscription by checking out',
{ exact: false }
)
})

8
services/web/test/frontend/features/subscription/components/successful-subscription/successful-subscription.test.tsx
View file

@ -41,7 +41,7 @@ describe('successful subscription page', function () {
/it’s support from people like yourself that allows .* to continue to grow and improve/i
)
expect(screen.getByText(/get the most out of your/i).textContent).to.match(
/get the most out of your .* subscription by checking out the list of .*’s premium features/i
/get the most out of your .* subscription by checking out .*’s features/i
)
expect(
screen
@ -70,11 +70,9 @@ describe('successful subscription page', function () {
)
const helpLink = screen.getByRole('link', {
name: /.*’s premium features/i,
name: /.*’s features/i,
})
expect(helpLink.getAttribute('href')).to.equal(
'/learn/how-to/Overleaf_premium_features'
)
expect(helpLink.getAttribute('href')).to.equal('/about/features-overview')
const backToYourProjectsLink = screen.getByRole('link', {
name: /back to your projects/i,