From 7a8af8a21a4616a429214d58aa6b5a1cf924b47e Mon Sep 17 00:00:00 2001 From: James Allen Date: Thu, 17 Nov 2016 16:05:12 +0000 Subject: [PATCH] Show file names in overview panel --- services/web/app/views/project/editor/review-panel.jade | 2 +- .../controllers/ReviewPanelController.coffee | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/services/web/app/views/project/editor/review-panel.jade b/services/web/app/views/project/editor/review-panel.jade index 138b54fdd8..3e82e56daa 100644 --- a/services/web/app/views/project/editor/review-panel.jade +++ b/services/web/app/views/project/editor/review-panel.jade @@ -43,7 +43,7 @@ ng-repeat="(doc_id, entries) in reviewPanel.entries" ) .rp-overview-file-header - | {{ doc_id }} + | {{ getFileName(doc_id) }} .rp-entry-wrapper( ng-repeat="(entry_id, entry) in entries" ) diff --git a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee index b08e0d1ae8..15bfbe9a29 100644 --- a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee +++ b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee @@ -151,6 +151,15 @@ define [ console.log "Going to entry", entry.docPos ide.editorManager.openDocId(doc_id, { gotoLine: entry.docPos.row + 1, gotoColumn: entry.docPos.column }) + DOC_ID_NAMES = {} + $scope.getFileName = (doc_id) -> + # This is called a lot and is relatively expensive, so cache the result + if !DOC_ID_NAMES[doc_id]? + entity = ide.fileTreeManager.findEntityById(doc_id) + return if !entity? + DOC_ID_NAMES[doc_id] = ide.fileTreeManager.getEntityPath(entity) + return DOC_ID_NAMES[doc_id] + # TODO: Eventually we need to get this from the server, and update it # when we get an id we don't know. This'll do for client side testing refreshUsers = () ->