From 78e8a8319d25ebb1446469a0f4026c8be2d638ee Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Fri, 24 Mar 2017 14:04:37 +0000 Subject: [PATCH] Put review panel widgets container inside the review panel element; rearrange visibility logic. --- .../app/views/project/editor/review-panel.pug | 28 +++++++++---------- .../stylesheets/app/editor/review-panel.less | 16 +++++++---- 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/services/web/app/views/project/editor/review-panel.pug b/services/web/app/views/project/editor/review-panel.pug index 89b0e05305..da14b69a99 100644 --- a/services/web/app/views/project/editor/review-panel.pug +++ b/services/web/app/views/project/editor/review-panel.pug @@ -1,18 +1,18 @@ -.rp-in-editor-widgets - a.rp-track-changes-indicator( - href - ng-if="editor.wantTrackChanges" - ng-click="toggleReviewPanel();" - ng-class="{ 'rp-track-changes-indicator-on-dark' : darkTheme }" - ) !{translate("track_changes_is_on")} - a.rp-add-comment-btn( - href - ng-if="reviewPanel.newAddCommentUI && reviewPanel.entries[editor.open_doc_id]['add-comment'] != null" - ng-click="addNewComment();" - ) - i.fa.fa-comment - |  #{translate("add_comment")} #review-panel + .rp-in-editor-widgets + a.rp-track-changes-indicator( + href + ng-if="editor.wantTrackChanges" + ng-click="toggleReviewPanel();" + ng-class="{ 'rp-track-changes-indicator-on-dark' : darkTheme }" + ) !{translate("track_changes_is_on")} + a.rp-add-comment-btn( + href + ng-if="reviewPanel.newAddCommentUI && reviewPanel.entries[editor.open_doc_id]['add-comment'] != null" + ng-click="addNewComment();" + ) + i.fa.fa-comment + |  #{translate("add_comment")} .review-panel-toolbar resolved-comments-dropdown( class="rp-flex-block" diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index c97c3bf9a3..3030e7dbb9 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -90,7 +90,7 @@ } #review-panel { - display: none; + display: block; .rp-size-expanded & { display: flex; flex-direction: column; @@ -98,7 +98,6 @@ overflow: visible; } .rp-size-mini & { - display: block; width: @review-off-width; z-index: 6; } @@ -152,7 +151,13 @@ } .rp-entry-list { + display: none; width: 100%; + + .rp-size-expanded &, + .rp-size-mini & { + display: block; + } .rp-state-current-file & { position: absolute; @@ -620,11 +625,12 @@ } .rp-nav { - display: flex; + display: none; flex-shrink: 0; - .rp-size-mini & { - display: none; + .rp-size-expanded & { + display: flex; } + .rp-state-current-file & { position: absolute; bottom: 0;