github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Allow NewletterManager to be called without a callback

Browse source
This commit is contained in:
James Allen 2014-02-13 12:37:23 +00:00
parent 8715690ce9
commit 768fd20850
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
services/web/app/coffee/managers/NewsletterManager.coffee
View file

@ -4,7 +4,7 @@ logger = require 'logger-sharelatex'
Settings = require 'settings-sharelatex' Settings = require 'settings-sharelatex'
module.exports = module.exports =
subscribe: (user, callback)-> subscribe: (user, callback = () ->)->
if !Settings.markdownmail? if !Settings.markdownmail?
logger.warn "No newsletter provider configured so not subscribing user" logger.warn "No newsletter provider configured so not subscribing user"
return callback() return callback()
@ -12,10 +12,9 @@ module.exports =
options = buildOptions(user, true) options = buildOptions(user, true)
Request.post options, (err, response, body)-> Request.post options, (err, response, body)->
logger.log body:body, user:user, "finished attempting to subscribe the user to the news letter" logger.log body:body, user:user, "finished attempting to subscribe the user to the news letter"
if callback? callback(err)
callback err
unsubscribe: (user, callback)-> unsubscribe: (user, callback = () ->)->
if !Settings.markdownmail? if !Settings.markdownmail?
logger.warn "No newsletter provider configured so not unsubscribing user" logger.warn "No newsletter provider configured so not unsubscribing user"
return callback() return callback()
@ -23,7 +22,7 @@ module.exports =
options = buildOptions(user, false) options = buildOptions(user, false)
Request.post options, (err, response, body)-> Request.post options, (err, response, body)->
logger.log err:err, body:body, email:user.email, "compled newsletter unsubscribe attempt" logger.log err:err, body:body, email:user.email, "compled newsletter unsubscribe attempt"
callback() callback(err)
buildOptions = (user, is_subscribed)-> buildOptions = (user, is_subscribed)->
options = options =