github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-04 22:47:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

[RedisManager] block updating of too large docs in redis

Browse source
This commit is contained in:
Jakob Ackermann 2021-05-06 17:30:50 +01:00
parent c707d0b345
commit 757e1e98c5
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/document-updater/app/js/RedisManager.js
View file

@ -468,6 +468,13 @@ module.exports = RedisManager = {
logger.error({ err: error, doc_id, newDocLines }, error.message)
return callback(error)
}
// Do a cheap size check on the serialized blob.
if (newDocLines.length > Settings.max_doc_length) {
const err = new Error('blocking doc update: doc is too large')
const docSize = newDocLines.length
logger.error({ project_id, doc_id, err, docSize }, err.message)
return callback(err)
}
const newHash = RedisManager._computeHash(newDocLines)
const opVersions = appliedOps.map((op) => (op != null ? op.v : undefined))