github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-20 05:11:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

add error handling for changing email in newsletter of user who has not subscribed

Browse source
This commit is contained in:
Henry Oswald 2018-08-28 10:47:33 +01:00
parent 740571475c
commit 75521a4c86
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/coffee/Features/Newsletter/NewsletterManager.coffee
View file

@ -39,8 +39,11 @@ module.exports =
delete options.body.status delete options.body.status
options.body.email_address = newEmail options.body.email_address = newEmail
mailchimp.request options, (err)-> mailchimp.request options, (err)->
if err? and err?.message?.indexOf("merge fields were invalid")
logger.log {oldEmail, newEmail}, "unable to change email in newsletter as user has not subscribed"
return callback()
# if the user has unsubscribed mailchimp will error on email address change # if the user has unsubscribed mailchimp will error on email address change
if err? and err?.message.indexOf("could not be validated") == -1 else if err? and err?.message?.indexOf("could not be validated") == -1
logger.err err:err, "error changing email in newsletter" logger.err err:err, "error changing email in newsletter"
return callback(err) return callback(err)
else else