Revert "Prepare new Pdf Preview rollout (#5664)" (#5745)

This reverts commit 047a3c636e09e9786c2a9b93514fef5bc46b0da9.

GitOrigin-RevId: 91b3c024cd364c1fd55d5e4fc6a2c592b784bc2a
This commit is contained in:
Miguel Serrano 2021-11-10 11:41:32 +01:00 committed by Copybot
parent 19eef0acca
commit 739ac96195
4 changed files with 2 additions and 32 deletions

View file

@ -38,7 +38,6 @@ function _getVariantForPercentile(percentile) {
} }
} }
// eslint-disable-next-line no-unused-vars
function getNewLogsUIVariantForUser(user) { function getNewLogsUIVariantForUser(user) {
const { _id: userId, alphaProgram: isAlphaUser } = user const { _id: userId, alphaProgram: isAlphaUser } = user
const isSaaS = Boolean(Settings.overleaf) const isSaaS = Boolean(Settings.overleaf)
@ -57,7 +56,5 @@ function getNewLogsUIVariantForUser(user) {
} }
module.exports = { module.exports = {
// We're disabling the split tests while rolling out the PDF Preview getNewLogsUIVariantForUser,
// https://github.com/overleaf/internal/issues/5553
getNewLogsUIVariantForUser: () => EXISTING_UI,
} }

View file

@ -733,27 +733,8 @@ const ProjectController = {
} }
) )
}, },
newPdfPreviewAssignment(cb) {
SplitTestV2Handler.getAssignmentForSession(
req.session,
'new-pdf-preview',
(err, assignment) => {
cb(err, assignment)
}
)
}, },
}, (err, { project, user, subscription, isTokenMember, brandVariation }) => {
(
err,
{
project,
user,
subscription,
isTokenMember,
brandVariation,
newPdfPreviewAssignment,
}
) => {
if (err != null) { if (err != null) {
OError.tag(err, 'error getting details for project page') OError.tag(err, 'error getting details for project page')
return next(err) return next(err)

View file

@ -9,11 +9,6 @@ const MODULE_PATH = require('path').join(
describe('NewLogsUI helper', function () { describe('NewLogsUI helper', function () {
let NewLogsUI let NewLogsUI
before(function () {
// We're disabling the Logs UI split test while rolling out the PDF Preview
this.skip()
})
function userIdFromTime(time) { function userIdFromTime(time) {
return ObjectId.createFromTime(time).toString() return ObjectId.createFromTime(time).toString()
} }

View file

@ -139,9 +139,6 @@ describe('ProjectController', function () {
getAssignment: sinon.stub().resolves({ active: false }), getAssignment: sinon.stub().resolves({ active: false }),
assignInLocalsContext: sinon.stub().resolves(), assignInLocalsContext: sinon.stub().resolves(),
}, },
getAssignmentForSession: sinon
.stub()
.yields(null, { variant: 'variant' }),
getAssignment: sinon.stub().yields(null, { active: false }), getAssignment: sinon.stub().yields(null, { active: false }),
assignInLocalsContext: sinon.stub().yields(null), assignInLocalsContext: sinon.stub().yields(null),
} }