github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Be more specific about the source-file-not-found error case

Browse source
This commit is contained in:
Shane Kilkelly 2018-05-22 11:36:35 +01:00
parent 1f2ee4e3fc
commit 73184c063e
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
services/web/app/coffee/Features/LinkedFiles/ProjectFileAgent.coffee
View file

@ -32,12 +32,12 @@ BadDataError = (message) ->
BadDataError.prototype.__proto__ = Error.prototype
FileNotFoundError = (message) ->
SourceFileNotFoundError = (message) ->
error = new Error(message)
error.name = 'BadData'
error.__proto__ = FileNotFoundError.prototype
error.__proto__ = SourceFileNotFoundError.prototype
return error
FileNotFoundError.prototype.__proto__ = Error.prototype
SourceFileNotFoundError.prototype.__proto__ = Error.prototype
module.exports = ProjectFileAgent =
@ -68,7 +68,7 @@ module.exports = ProjectFileAgent =
}, (err, entity, type) ->
if err?
if err.toString().match(/^not found.*/)
err = new FileNotFoundError()
err = new SourceFileNotFoundError()
return callback(err)
ProjectFileAgent._writeEntityToDisk source_project_id, entity._id, type, callback
@ -92,8 +92,8 @@ module.exports = ProjectFileAgent =
res.status(400).send("The submitted data is not valid")
else if error instanceof BadEntityTypeError
res.status(400).send("The file is the wrong type")
else if error instanceof FileNotFoundError
res.status(404).send("File not found")
else if error instanceof SourceFileNotFoundError
res.status(404).send("Source file not found")
else
next(error)
next()