From 72ebaea5e24d355d1c2ebb0b8983a301f52a431f Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Mon, 22 Dec 2014 11:11:31 +0000 Subject: [PATCH] log FS delete errors only on failure --- services/filestore/app/coffee/FSPersistorManager.coffee | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/services/filestore/app/coffee/FSPersistorManager.coffee b/services/filestore/app/coffee/FSPersistorManager.coffee index 94ededd700..d00b112c27 100644 --- a/services/filestore/app/coffee/FSPersistorManager.coffee +++ b/services/filestore/app/coffee/FSPersistorManager.coffee @@ -59,13 +59,16 @@ module.exports = filteredName = filterName name logger.log location:location, name:filteredName, "delete file" fs.unlink "#{location}/#{filteredName}", (err) -> - logger.err err:err, location:location, name:filteredName, "Error on delete." - callback err + if err? + logger.err err:err, location:location, name:filteredName, "Error on delete." + callback err + else + callback() deleteDirectory: (location, name, callback = (err)->)-> filteredName = filterName name.replace(/\/$/,'') rimraf "#{location}/#{filteredName}", (err) -> - if err + if err? logger.err err:err, location:location, name:filteredName, "Error on rimraf rmdir." callback err else