From 6e123b873d4267223da3a13432e8456378689618 Mon Sep 17 00:00:00 2001
From: Jakob Ackermann <jakob.ackermann@overleaf.com>
Date: Thu, 29 Apr 2021 15:30:53 +0100
Subject: [PATCH] [misc] add linting for missing explicit dependencies and fix
 any errors

---
 services/chat/.eslintrc       | 13 +++++++++++--
 services/chat/buildscript.txt |  2 +-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/services/chat/.eslintrc b/services/chat/.eslintrc
index 76dad1561d..321353f971 100644
--- a/services/chat/.eslintrc
+++ b/services/chat/.eslintrc
@@ -22,7 +22,10 @@
   "rules": {
     // Swap the no-unused-expressions rule with a more chai-friendly one
     "no-unused-expressions": 0,
-    "chai-friendly/no-unused-expressions": "error"
+    "chai-friendly/no-unused-expressions": "error",
+
+    // Do not allow importing of implicit dependencies.
+    "import/no-extraneous-dependencies": "error"
   },
   "overrides": [
     {
@@ -57,7 +60,13 @@
       "files": ["app/**/*.js", "app.js", "index.js"],
       "rules": {
         // don't allow console.log in backend code
-        "no-console": "error"
+        "no-console": "error",
+
+        // Do not allow importing of implicit dependencies.
+        "import/no-extraneous-dependencies": ["error", {
+          // Do not allow importing of devDependencies.
+          "devDependencies": false
+        }]
       }
     }
   ]
diff --git a/services/chat/buildscript.txt b/services/chat/buildscript.txt
index 798f58f99e..611c611e8d 100644
--- a/services/chat/buildscript.txt
+++ b/services/chat/buildscript.txt
@@ -5,4 +5,4 @@ chat
 --env-pass-through=
 --node-version=12.21.0
 --public-repo=False
---script-version=3.7.0
+--script-version=3.8.0