github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #12187 from overleaf/jpa-mf-old-plans-page-annual-variant

Browse source 
Differentiate user that visits from before the fix and after the fix

GitOrigin-RevId: 4c3c4b47dc3329b97da79adcb2a45bf95b0ff27a
This commit is contained in:
Jakob Ackermann 2023-03-10 16:23:42 +00:00 committed by Copybot
parent 7ae5a9f060
commit 6da00de5ea
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/web/app/src/Features/Subscription/SubscriptionController.js
View file

@ -64,6 +64,12 @@ async function plansPage(req, res) {
res, res,
'plans-page-layout-v3' 'plans-page-layout-v3'
) )
if (plansPageLayoutV3Assignment.variant === 'old-plans-page-annual') {
plansPageLayoutV3Assignment.variant = 'old-plans-page-annual-fixed'
res.locals.splitTestVariants['plans-page-layout-v3'] =
'old-plans-page-annual-fixed'
}
} catch (error) { } catch (error) {
logger.error( logger.error(
{ err: error }, { err: error },
@ -73,7 +79,7 @@ async function plansPage(req, res) {
let currentView = 'monthly' let currentView = 'monthly'
if ( if (
plansPageLayoutV3Assignment.variant === 'old-plans-page-annual' || plansPageLayoutV3Assignment.variant === 'old-plans-page-annual-fixed' ||
plansPageLayoutV3Assignment.variant === 'new-plans-page' plansPageLayoutV3Assignment.variant === 'new-plans-page'
) { ) {
currentView = 'annual' currentView = 'annual'

2
services/web/app/views/subscriptions/plans-marketing.pug
View file

@ -63,7 +63,7 @@ block content
h2 #{translate('compare_plan_features')} h2 #{translate('compare_plan_features')}
.row .row
.col-md-6.col-md-offset-3 .col-md-6.col-md-offset-3
if (plansPageLayoutV3Variant === 'old-plans-page-annual') if (plansPageLayoutV3Variant === 'old-plans-page-annual-fixed')
+plan_switch_annual_default('table') +plan_switch_annual_default('table')
else else
+plan_switch('table') +plan_switch('table')

2
services/web/app/views/subscriptions/plans-marketing/_mixins.pug
View file

@ -240,7 +240,7 @@ mixin allCardsAndControls(controlsRowSpaced, listLocation)
- var location = listLocation ? 'card_' + listLocation : 'card' - var location = listLocation ? 'card_' + listLocation : 'card'
.row.top-switch(class=(controlsRowSpaced ? "row-spaced" : "")) .row.top-switch(class=(controlsRowSpaced ? "row-spaced" : ""))
.col-md-6.col-md-offset-3 .col-md-6.col-md-offset-3
if (plansPageLayoutV3Variant === 'old-plans-page-annual') if (plansPageLayoutV3Variant === 'old-plans-page-annual-fixed')
+plan_switch_annual_default(location) +plan_switch_annual_default(location)
else else
+plan_switch(location) +plan_switch(location)