github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-13 10:32:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ContentCacheManager] write streams to disk atomically

Browse source 
Use an intermediate file for writing to disk, then rename to the target.
This commit is contained in:
Jakob Ackermann 2021-05-17 14:18:07 +01:00
parent b456ea726d
commit 6b9c8bced6
1 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
services/clsi/app/js/ContentCacheManager.js
View file

@ -100,17 +100,27 @@ async function writePdfStream(dir, hash, buffers) {
// ETags used for client side caching via browser internals.
return false
} catch (e) {}
const file = await fs.promises.open(filename, 'w')
const atomicWriteFilename = filename + '~'
const file = await fs.promises.open(atomicWriteFilename, 'w')
if (Settings.enablePdfCachingDark) {
// Write an empty file in dark mode.
buffers = []
}
try {
for (const buffer of buffers) {
await file.write(buffer)
try {
for (const buffer of buffers) {
await file.write(buffer)
}
} finally {
await file.close()
}
await fs.promises.rename(atomicWriteFilename, filename)
} catch (err) {
try {
await fs.promises.unlink(atomicWriteFilename)
} catch (_) {
throw err
}
} finally {
await file.close()
}
return true
}