github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-05 16:01:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2300 from overleaf/jel-institution-register

Browse source 
Institution SSO register notification

GitOrigin-RevId: 6838b4f950f9841911da97234d1292802d3ea451
This commit is contained in:
Jessica Lawshe 2019-11-06 07:41:08 -06:00 committed by sharelatex
parent 9a252b6629
commit 67a5f08192
2 changed files with 25 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/src/Features/Project/ProjectController.js
View file

@ -506,7 +506,10 @@ const ProjectController = {
}
// Notification: Tried to register, but account already existed
if (samlSession.registerIntercept) {
// registerIntercept is set before the institution callback.
// institutionEmail is set after institution callback.
// Check for both in case SSO flow was abandoned
if (samlSession.registerIntercept && samlSession.institutionEmail) {
notificationsInstitution.push({
email: samlSession.institutionEmail,
templateKey: 'notification_institution_sso_already_registered'

22
services/web/test/unit/src/Project/ProjectControllerTests.js
View file

@ -747,7 +747,27 @@ describe('ProjectController', function() {
hasEntitlement: false,
universityName: 'Overleaf'
},
registerIntercept: true
registerIntercept: {
id: 1,
name: 'Example University'
}
}
this.ProjectController.projectListPage(this.req, this.res)
})
it('should not show a register notification if the flow was abandoned', function() {
// could initially start to register with an SSO email and then
// abandon flow and login with an existing non-institution SSO email
this.res.render = (pageName, opts) => {
expect(opts.notificationsInstitution).to.deep.not.include({
email: 'test@overleaf.com',
templateKey: 'notification_institution_sso_already_registered'
})
}
this.req.session.saml = {
registerIntercept: {
id: 1,
name: 'Example University'
}
}
this.ProjectController.projectListPage(this.req, this.res)
})