From 6ff3a2de9ff984bea6998a4f8d292b6c245d756a Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Tue, 17 Oct 2017 15:04:27 +0100 Subject: [PATCH 1/2] Rollout autocompile to 1% of users and improve readability --- .../web/app/coffee/Features/Project/ProjectController.coffee | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index 68d2c49bca..d9a3664165 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -257,8 +257,8 @@ module.exports = ProjectController = timestamp = parseInt(user_id.toString().substring(0, 8), 16) counter = parseInt(user_id.toString().substring(18, 24), 16) - rolloutProportion = 0 - if counter % 1000 >= rolloutProportion + rolloutPercentage = 1 # Percentage of users to roll out to + if counter % 1000 > rolloutPercentage # Don't show if user is not part of roll out return cb(null, false) userSignupDate = new Date(timestamp * 1000) From b0dc84748abb9ada18b89320905ac922ef559df0 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Tue, 17 Oct 2017 15:44:15 +0100 Subject: [PATCH 2/2] Fix to actual percentage --- .../web/app/coffee/Features/Project/ProjectController.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/app/coffee/Features/Project/ProjectController.coffee b/services/web/app/coffee/Features/Project/ProjectController.coffee index d9a3664165..d210d5d40a 100644 --- a/services/web/app/coffee/Features/Project/ProjectController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectController.coffee @@ -258,7 +258,7 @@ module.exports = ProjectController = counter = parseInt(user_id.toString().substring(18, 24), 16) rolloutPercentage = 1 # Percentage of users to roll out to - if counter % 1000 > rolloutPercentage + if counter % 100 > rolloutPercentage # Don't show if user is not part of roll out return cb(null, false) userSignupDate = new Date(timestamp * 1000)