github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-24 17:33:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1814 from overleaf/spd-missing-callback-returns

Browse source 
Add missing return statements to callbacks in SubscriptionGroupHandler

GitOrigin-RevId: 05ff67bd8e4997fde01c6cf9f4558d3caa261590
This commit is contained in:
Simon Detheridge 2019-05-28 10:15:55 +01:00 committed by sharelatex
parent 561f54c1a3
commit 6488fd1284
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/coffee/Features/Subscription/SubscriptionGroupHandler.coffee
View file

@ -18,11 +18,12 @@ module.exports = SubscriptionGroupHandler =
SubscriptionUpdater.removeUserFromGroup subscriptionId, userToRemove_id, callback
replaceUserReferencesInGroups: (oldId, newId, callback) ->
logger.log old_id: oldId, new_id: newId, "replacing user reference in groups"
Subscription.update {admin_id: oldId}, {admin_id: newId}, (error) ->
callback(error) if error?
return callback(error) if error?
replaceInArray Subscription, "manager_ids", oldId, newId, (error) ->
callback(error) if error?
return callback(error) if error?
replaceInArray Subscription, "member_ids", oldId, newId, callback