From 63fa024d98c8008d34d75baa99f9d4fd77ee5a03 Mon Sep 17 00:00:00 2001
From: Brian Gough <bjg@network-theory.co.uk>
Date: Mon, 29 Jan 2018 15:24:51 +0000
Subject: [PATCH] client-side duplicate check for move/rename/create

---
 .../ide/file-tree/FileTreeManager.coffee      | 26 +++++++++++++++++++
 .../web/public/coffee/ide/services/ide.coffee |  3 ++-
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/services/web/public/coffee/ide/file-tree/FileTreeManager.coffee b/services/web/public/coffee/ide/file-tree/FileTreeManager.coffee
index d46525bf20..4b8af090bc 100644
--- a/services/web/public/coffee/ide/file-tree/FileTreeManager.coffee
+++ b/services/web/public/coffee/ide/file-tree/FileTreeManager.coffee
@@ -321,7 +321,20 @@ define [
 
 			return null
 
+		existsInThisFolder: (folder, name) ->
+			for entity in folder?.children or []
+				return true if entity.name is name
+			return false
+
+		nameExistsError: (message = "already exists") ->
+			nameExists = @ide.$q.defer()
+			nameExists.reject({data: message})
+			return nameExists.promise
+
 		createDoc: (name, parent_folder = @getCurrentFolder()) ->
+			# check if a doc/file/folder already exists with this name
+			if @existsInThisFolder parent_folder, name
+				return @nameExistsError()
 			# We'll wait for the socket.io notification to actually
 			# add the doc for us.
 			@ide.$http.post "/project/#{@ide.project_id}/doc", {
@@ -331,6 +344,9 @@ define [
 			}
 
 		createFolder: (name, parent_folder = @getCurrentFolder()) ->
+			# check if a doc/file/folder already exists with this name
+			if @existsInThisFolder parent_folder, name
+				return @nameExistsError()
 			# We'll wait for the socket.io notification to actually
 			# add the folder for us.
 			return @ide.$http.post "/project/#{@ide.project_id}/folder", {
@@ -342,6 +358,12 @@ define [
 		renameEntity: (entity, name, callback = (error) ->) ->
 			return if entity.name == name
 			return if name.length >= 150
+			# check if a doc/file/folder already exists with this name
+			parent_folder = @getCurrentFolder()
+			if @existsInThisFolder parent_folder, name
+				return @nameExistsError()
+			# We'll wait for the socket.io notification to actually
+			# do the rename for us.
 			@ide.$http.post("/project/#{@ide.project_id}/#{entity.type}/#{entity.id}/rename", {
 				name: name,
 				_csrf: window.csrfToken
@@ -362,6 +384,10 @@ define [
 			# Abort move if the folder being moved (entity) has the parent_folder as child
 			# since that would break the tree structure.
 			return if @_isChildFolder(entity, parent_folder)
+			# check if a doc/file/folder already exists with this name
+			if @existsInThisFolder entity.name, parent_folder
+				return @nameExistsError()
+			# Wait for the http response before doing the move
 			@ide.queuedHttp.post("/project/#{@ide.project_id}/#{entity.type}/#{entity.id}/move", {
 				folder_id: parent_folder.id
 				_csrf: window.csrfToken
diff --git a/services/web/public/coffee/ide/services/ide.coffee b/services/web/public/coffee/ide/services/ide.coffee
index 57e0bbef3d..6462859df2 100644
--- a/services/web/public/coffee/ide/services/ide.coffee
+++ b/services/web/public/coffee/ide/services/ide.coffee
@@ -3,10 +3,11 @@ define [
 ], (App) ->
 	# We create and provide this as service so that we can access the global ide
 	# from within other parts of the angular app.
-	App.factory "ide", ["$http", "queuedHttp", "$modal", ($http, queuedHttp, $modal) ->
+	App.factory "ide", ["$http", "queuedHttp", "$modal", "$q", ($http, queuedHttp, $modal, $q) ->
 		ide = {}
 		ide.$http = $http
 		ide.queuedHttp = queuedHttp
+		ide.$q = $q
 
 		@recentEvents = []
 		ide.pushEvent = (type, meta = {}) =>