From 6002fdbad60b2dd3d42d8e6ce0537d6f20079a40 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Tue, 28 Mar 2017 10:30:53 +0100 Subject: [PATCH] return 404 on project details not found --- .../coffee/Features/Project/ProjectApiController.coffee | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/services/web/app/coffee/Features/Project/ProjectApiController.coffee b/services/web/app/coffee/Features/Project/ProjectApiController.coffee index b16991ac62..715ccf19ae 100644 --- a/services/web/app/coffee/Features/Project/ProjectApiController.coffee +++ b/services/web/app/coffee/Features/Project/ProjectApiController.coffee @@ -1,4 +1,5 @@ ProjectDetailsHandler = require("./ProjectDetailsHandler") +Errors = require("../Errors/Errors") logger = require("logger-sharelatex") @@ -7,8 +8,11 @@ module.exports = getProjectDetails : (req, res)-> {project_id} = req.params ProjectDetailsHandler.getDetails project_id, (err, projDetails)-> - if err? + if err? and err instanceof Errors.NotFoundError + return res.sendStatus 404 + else if err? logger.log err:err, project_id:project_id, "something went wrong getting project details" return res.sendStatus 500 - res.json(projDetails) + else + res.json(projDetails)