github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #300 from sharelatex/revert-295-msw-history-failure

Browse source 
Revert "Bail out if history API request fails"
This commit is contained in:
Shane Kilkelly 2018-02-01 12:50:42 +00:00 committed by GitHub
commit 5ff4493d6b
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/coffee/Features/History/HistoryController.coffee
View file

@ -46,14 +46,9 @@ module.exports = HistoryController =
"X-User-Id": user_id "X-User-Id": user_id
}, (error, response, body) -> }, (error, response, body) ->
return next(error) if error? return next(error) if error?
if 200 <= res.statusCode < 300
HistoryManager.injectUserDetails body, (error, data) -> HistoryManager.injectUserDetails body, (error, data) ->
return next(error) if error? return next(error) if error?
res.json data res.json data
else
error = new Error("history api responded with non-success code: #{res.statusCode}")
logger.error err: error, user_id: user_id, "error proxying request to history api"
next(error)
buildHistoryServiceUrl: (useProjectHistory) -> buildHistoryServiceUrl: (useProjectHistory) ->
# choose a history service, either document-level (trackchanges) # choose a history service, either document-level (trackchanges)